Closed
Conversation
…leaned up ones CurseForge, Modrinth, and GitHub releases use
Member
|
This isn't going to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix CHANGELOG.md using autogenerated changelogs instead of the cleaned up ones CurseForge, Modrinth, and GitHub releases use
Implementation Details
Made it use the changelogs from the GitHub release and only generate the header part
Outcome
better changelogs in CHANGELOG.md that are also consistent with changelogs everywhere else
How Was This Tested
on my fork
Additional Information
I merged the
publish-modrinthandpublish-cfjobs in release.yml and made them usefail-mode: skipinstead offail-mode: failso the other still runs even if one fails.Tell me if this should be reverted.