Skip to content

Remove more ldlib stuff#4705

Closed
gustovafing wants to merge 9 commits intomui2-refactorfrom
gus/remove-ldlib-stuff
Closed

Remove more ldlib stuff#4705
gustovafing wants to merge 9 commits intomui2-refactorfrom
gus/remove-ldlib-stuff

Conversation

@gustovafing
Copy link
Member

What

  • Removes usages of LDLib util classes
  • Removes a bunch of UI api stuff that is now unused
  • Remove all ldlib machine UI stuff, as all machine UIs now use MUI.

@gustovafing gustovafing requested a review from a team as a code owner March 2, 2026 03:49
@gustovafing gustovafing added type: refactor Suggestion to refactor a section of code Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. labels Mar 2, 2026
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Mar 2, 2026
@YoungOnionMC YoungOnionMC added the Do Not Merge DO NOT MERGE THIS PR YET! label Mar 2, 2026
@YoungOnionMC
Copy link
Member

This should be broken up into atleast 3 or 4 prs, namely
one for the moving of inworld texture usage from UITexture to GuiTextures,
one for the removal of the ldlib custom widget classes,
one for the multiblock data structure migration from ldlib to base(this also is already done in #3119 ),
one for the builder util classes cleanup, etc etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the multiblock preview changes should be done with the other multiblock pattern API changes in #3119 simply because this class is abysmal and should not be recreated.

@gustovafing gustovafing closed this Mar 2, 2026
@gustovafing gustovafing deleted the gus/remove-ldlib-stuff branch March 20, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge DO NOT MERGE THIS PR YET! Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. Tests: Passed Game Tests have passed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants