Major Update #9
Open
Major Update #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner is ready. Rename the event the mongodb connection emits to be more informative.
…ent variables for PORT, DATABASE connection strings, and NODE_ENV. - Created docker compose file for dev in the root directory of the project that can startup the backend and a mongodb instance. - Modified app.js to use our mongoose.js connection code. - Updated project .gitignore so that it ignores a data directory that mongo creates to store all of our database data.
…ewares for performance/functionality
All endpoints are now defined in a routes file per object that is stored in the database. get/set settings are defined as a single /settings resource with POST and GET endpoints. - POST /settings corresponds to the old /setSettings endpoint - GET /settings corresponds to the old /getSettings endpoint. get monitors is now defined as a single /status resource with a GET endpoint. - GET /status corresponds to the old /getMonitors endpoint.
Fixed mistake in the Settings api POST endpoint
Added in loading of API endpoints for express app.
- Updated docker-compose-dev file to include frontend and linked it to backend. - Updated GUI package.json proxy to proxy to the docker-compose backend service. - Updated GUI app.js to use the new endpoints in the backend service for fetching data.
…an now pass in the location of the backend API via environment variables. - Removed React proxy from package.json until react proxy can be configured through environment variables. - Updated gui/src/App.js to use the environment variables for the api location when making requests.
…ow to start the service with docker or docker-compose, and how to configure the service with environment variables
- How to setup docker/docker-compose - How to start the backend service as either a standalone container or as part of a docker-compose full system. - How to configure the container with its environemnt variables. - Structure of the REST API resources, endpoints, and examples of how to make requests.
- Fixed typo for directory name. Frontend Readme - Added information on how to start the frontend as either a standalone container with docker. Or as a full software system with docker-compose
|
This PR also includes documentation for all the changes made to the backend and gui services within their respective folders @ README.md |
|
@ljyanesm If I refactor this to fix the new conflicts is there a chance of it being merged? |
|
Hi @ethanwillis , |
|
@homonecloco no worries :) I'll have some time this weekend to resolve the current conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues #2, #5, #6, #8.
This includes a partial fix for #7. The docker-compose setup does not currently run the daemon. That will happen once issues #3 and issues #4 are resolved. Those are dependent on rewriting the daemon with cylon.js.