Fix hard crash in plOGGCodec when opening an .ogg file containing invalid data
#1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash when an .ogg file contains invalid data, in which case IOpen calls IClose, which would attempt to free the uninitialized fHeadBuf pointer.
Hoikas
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handling code here was broken and tried to free a not yet initialized pointer. This PR adjusts the initialization order to fix that.
Also improved the error messages to include the specific error code returned by libvorbis, along with a description of the error code, if possible.
(The error reporting in plAudioCore could use some improvements in general. Currently, everything is reported via
hsAssert, rather than returning the error message to the caller. But that is work for another time.)