Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the .gitattributes file #5268

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Simplify the .gitattributes file #5268

merged 1 commit into from
Jan 24, 2025

Conversation

derobins
Copy link
Member

  • Removes all per-file attributes, many of which were incorrectly removing the text attribute from text/source files
  • Removes all svneol attributes (not sure where those came from, but they don't appear in the git attributes docs)
  • Marks *.h5 and certain test files as binary
  • Removes the !eol attribute, which is unnecessary given text=auto and default git text handling

Simplify the .gitattributes file
233a023 
* Removes all per-file attributes, many of which were incorrectly
  removing the text attribute from text/source files
* Removes all svneol attributes (not sure where those came from, but
  they don't appear in the git attributes docs)
* Marks *.h5 and certain test files as binary
* Removes the !eol attribute, which is unnecessary given text=auto
  and default git text handling
@derobins derobins added Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality Component - Misc Anything else (CODEOWNERS, etc.) labels Jan 24, 2025
@derobins
Copy link
Member Author

derobins commented Jan 24, 2025 •
edited
Loading

text=auto will handle common binary formats like jpg and jar. Even marking HDF5 files as binary is probably overkill.

Helpful git attribute docs:

https://git-scm.com/docs/gitattributes

Also, FWIW, the crazy attributes are from the svn --> git migration we did back in 2016.

@lrknox lrknox merged commit 455601a into HDFGroup:develop Jan 24, 2025
76 checks passed
byrnHDF pushed a commit to byrnHDF/hdf5 that referenced this pull request Feb 10, 2025
@derobins @byrnHDF
Simplify the .gitattributes file (HDFGroup#5268)
d737944 
* Removes all per-file attributes, many of which were incorrectly
  removing the text attribute from text/source files
* Removes all svneol attributes (not sure where those came from, but
  they don't appear in the git attributes docs)
* Marks *.h5 and certain test files as binary
* Removes the !eol attribute, which is unnecessary given text=auto
  and default git text handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Misc Anything else (CODEOWNERS, etc.) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @lrknox @byrnHDF