Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project to target Node.js 24 and aligns runtime/dev dependencies and small compatibility shims with the upgraded ecosystem.
Changes:
- Bumped Node engine/CI matrix to Node 24 and added
.nvmrc. - Upgraded dependencies (notably
connect-redis,nocache,redis,chai/sinontoolchain) and adjusted imports accordingly. - Added explicit
Pragma: no-cacheheader innocachemiddleware and adjusted tests; updated loggerget()to avoid pre-increment.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Sets Node engine to 24.x, upgrades deps/devDeps, updates peer deps, and adds overrides. |
.github/workflows/ci.yaml |
Runs CI on Node 24.x only. |
.nvmrc |
Pins local Node version to v24.14.0. |
.npmrc |
Adds npm config min-release-age=2. |
middleware/session.js |
Updates connect-redis usage to v9 API (RedisStore import). |
middleware/nocache.js |
Restores Pragma header behavior removed by nocache v4. |
test/unit/middleware/spec.nocache.js |
Updates header-order expectations to match new middleware behavior. |
test/unit/helper.js |
Updates sinon-chai import style for the upgraded version. |
lib/logger.js |
Changes get() stack-level adjustment to avoid mutating the argument. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
18d0364 to
cd98fd4
Compare
cd98fd4 to
7613cdd
Compare
ntotten-hmpo
approved these changes
Mar 20, 2026
Contributor
ntotten-hmpo
left a comment
There was a problem hiding this comment.
Nice work, and good catches with the dep upgrades.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getin logger to not incrementlevelsince it was failing eslint checks