Skip to content

FOR-813 Upgrade to Node 24#45

Open
leonardobishop-hmpo wants to merge 1 commit intomasterfrom
FOR-813-node-24
Open

FOR-813 Upgrade to Node 24#45
leonardobishop-hmpo wants to merge 1 commit intomasterfrom
FOR-813-node-24

Conversation

@leonardobishop-hmpo
Copy link

@leonardobishop-hmpo leonardobishop-hmpo commented Mar 20, 2026

  • Upgraded deps to latest (except redis, connect-redis, and express), set engine to 24 in package.json & CI
  • Updated import for sinon-chai following upgrade
  • Manually added the Pragma header in nocache middleware since the nocache package no longer adds it in the latest version
  • Updated get in logger to not increment level since it was failing eslint checks

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project to target Node.js 24 and aligns runtime/dev dependencies and small compatibility shims with the upgraded ecosystem.

Changes:

  • Bumped Node engine/CI matrix to Node 24 and added .nvmrc.
  • Upgraded dependencies (notably connect-redis, nocache, redis, chai/sinon toolchain) and adjusted imports accordingly.
  • Added explicit Pragma: no-cache header in nocache middleware and adjusted tests; updated logger get() to avoid pre-increment.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Sets Node engine to 24.x, upgrades deps/devDeps, updates peer deps, and adds overrides.
.github/workflows/ci.yaml Runs CI on Node 24.x only.
.nvmrc Pins local Node version to v24.14.0.
.npmrc Adds npm config min-release-age=2.
middleware/session.js Updates connect-redis usage to v9 API (RedisStore import).
middleware/nocache.js Restores Pragma header behavior removed by nocache v4.
test/unit/middleware/spec.nocache.js Updates header-order expectations to match new middleware behavior.
test/unit/helper.js Updates sinon-chai import style for the upgraded version.
lib/logger.js Changes get() stack-level adjustment to avoid mutating the argument.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leonardobishop-hmpo leonardobishop-hmpo force-pushed the FOR-813-node-24 branch 4 times, most recently from 18d0364 to cd98fd4 Compare March 20, 2026 13:05
Copy link
Contributor

@ntotten-hmpo ntotten-hmpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and good catches with the dep upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants