TRP-914 Updated runtime to Node 24 and resolved vulnerabilities#39
Merged
samdagnall merged 1 commit intomasterfrom Mar 12, 2026
Merged
TRP-914 Updated runtime to Node 24 and resolved vulnerabilities#39samdagnall merged 1 commit intomasterfrom
samdagnall merged 1 commit intomasterfrom
Conversation
a92baf7 to
b87030b
Compare
b87030b to
3c908a9
Compare
Contributor
Author
|
Tested through publishing version of web-middleware |
Contributor
Author
|
Tested as well with hmpo-countries-lib as another dependency |
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s runtime/tooling baseline to Node.js 24 and refreshes core dependencies to versions compatible with Node 24, with additional steps intended to reduce known vulnerability exposure.
Changes:
- Updated CI and
package.jsonengines to require Node 24 (dropping Node 20/22). - Upgraded key dependencies/devDependencies (notably
hmpo-model,mocha,sinon,hmpo-logger) for Node 24 compatibility. - Added
.nvmrc,.npmrc, and an npmoverridesentry to address dependency/vulnerability concerns.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Switches engine to Node 24, updates deps, changes audit invocation, adds overrides. |
| package-lock.json | Refreshes the lockfile to reflect updated dependency graph under Node 24/npm. |
| .nvmrc | Pins local Node version to v24.14.0. |
| .npmrc | Adds npm config intended to enforce a minimum package release age. |
| .github/workflows/ci.yaml | Updates CI matrix to run on Node 24 only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
leonardobishop-hmpo
approved these changes
Mar 12, 2026
leeservice
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.