TRP-915 Updated to Node 24 and resolved vulnerabilities#52
Merged
samdagnall merged 1 commit intomasterfrom Mar 16, 2026
Merged
Conversation
3bd548c to
fc4e9d1
Compare
There was a problem hiding this comment.
Pull request overview
Updates this Node library’s runtime/tooling baseline to Node 24 and refreshes dependencies to address reported vulnerabilities.
Changes:
- Bumps Node engine requirement to 24.x and updates CI to run on Node 24 only.
- Updates key dependencies/devDependencies (e.g.,
hmpo-cached-model,mocha,sinon) and adds npmoverridesfor vulnerable transitive packages. - Adds
.nvmrc(and intends to add.npmrcpolicy per PR description).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates Node engine, dependency versions, audit command, and adds overrides for vulnerable transitive deps |
| .nvmrc | Pins local Node version to v24.14.0 |
| .npmrc | Included in PR metadata, but currently empty in the branch snapshot |
| .github/workflows/ci.yaml | Updates CI matrix to only run on Node 24.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
318aab2 to
9ace518
Compare
Contributor
Author
|
Tested on a downstream dependency of web-apply running tests. Local testing screenshots have been added to the ticket. |
ntotten-hmpo
previously approved these changes
Mar 13, 2026
9ace518 to
9ad850f
Compare
leonardobishop-hmpo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.