Skip to content

TRP-915 Updated to Node 24 and resolved vulnerabilities#52

Merged
samdagnall merged 1 commit intomasterfrom
feature/TRP-915-Updating-To-Node24
Mar 16, 2026
Merged

TRP-915 Updated to Node 24 and resolved vulnerabilities#52
samdagnall merged 1 commit intomasterfrom
feature/TRP-915-Updating-To-Node24

Conversation

@samdagnall
Copy link
Contributor

@samdagnall samdagnall commented Mar 13, 2026

  • Updated package.json runtime to Node 24 and removed support for Node 20/22
  • Updated github ci workflow to run on Node 24 and removed support for Node 20/22
  • Added .nvmrc with version v24.14.0
  • Added .npmrc with min-release-age=2 to prevent packages from being installed that are < 2 days old
  • Bumped hmpo-cached-model to v7.0.0 with Node 24 support
  • Updated sinon and mocha version in package.json
  • Added override for serialize-javascript and diff to resolve vulnerabilities
  • Changed main field in package.json to point to /lib/index.js

@samdagnall samdagnall force-pushed the feature/TRP-915-Updating-To-Node24 branch from 3bd548c to fc4e9d1 Compare March 13, 2026 12:01
@samdagnall samdagnall requested a review from Copilot March 13, 2026 12:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this Node library’s runtime/tooling baseline to Node 24 and refreshes dependencies to address reported vulnerabilities.

Changes:

  • Bumps Node engine requirement to 24.x and updates CI to run on Node 24 only.
  • Updates key dependencies/devDependencies (e.g., hmpo-cached-model, mocha, sinon) and adds npm overrides for vulnerable transitive packages.
  • Adds .nvmrc (and intends to add .npmrc policy per PR description).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
package.json Updates Node engine, dependency versions, audit command, and adds overrides for vulnerable transitive deps
.nvmrc Pins local Node version to v24.14.0
.npmrc Included in PR metadata, but currently empty in the branch snapshot
.github/workflows/ci.yaml Updates CI matrix to only run on Node 24.x

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@samdagnall samdagnall force-pushed the feature/TRP-915-Updating-To-Node24 branch 4 times, most recently from 318aab2 to 9ace518 Compare March 13, 2026 13:19
@samdagnall
Copy link
Contributor Author

Tested on a downstream dependency of web-apply running tests. Local testing screenshots have been added to the ticket.

  3647 passing (4s)


=============================== Coverage summary ===============================
Statements   : 100% ( 2202/2202 )
Branches     : 100% ( 1160/1160 )
Functions    : 100% ( 406/406 )
Lines        : 100% ( 2122/2122 )
================================================================================
----------------------------------------|---------|----------|---------|---------|-------------------
File                                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------------------------------------|---------|----------|---------|---------|-------------------
----------------------------------------|---------|----------|---------|---------|-------------------

> web-apply@1.0.0 posttest
> check-audit --registry='https://registry.npmjs.org'

>>>> npm audit --json --registry https://registry.npmjs.org
Total of 1 actions to process
audit ok.
➜  web-apply git:(CHORE-testing-hmpo-countries-lib-upgrade) ✗ 

ntotten-hmpo
ntotten-hmpo previously approved these changes Mar 13, 2026
@samdagnall samdagnall merged commit d4bc4f4 into master Mar 16, 2026
1 check passed
@samdagnall samdagnall deleted the feature/TRP-915-Updating-To-Node24 branch March 16, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants