DD-749 Update example app dependency for expressjs to fix pathToRegexpError#215
Merged
cmcgee4801995 merged 1 commit intomasterfrom Jul 9, 2025
Merged
Conversation
imran-gov
previously approved these changes
Jul 8, 2025
cmcgee4801995
force-pushed
the
DD-749-fix-example-app-dependency-issue
branch
from
58bb833 to
f77aa2b
Compare
imran-gov
approved these changes
Jul 8, 2025
… causing issues with express 5
cmcgee4801995
force-pushed
the
DD-749-fix-example-app-dependency-issue
branch
from
f77aa2b to
771152a
Compare
|
Hi all! I thought I would point out a different solution to this that I’d made a pull request for: it’s actually a fairly small change that’s needed to the controller to make it work with express 4 and 5. This is because using a regular expression in place of a path means that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned the Express dependency to a v4.x version in the example app as previous "latest" tag was bringing in Express v5.x, which is not compatible with this app yet and was causing a pathToRegexpError, leading to npm start failures.