Merged
Conversation
matthewdoreilly
approved these changes
Mar 6, 2026
Updated regex in pretty.js:60 to make the capture of "[Object: null prototype] " optional as as sort-object-keys 2.x no longer recreates the object with a null prototype.
leonardobishop-hmpo
force-pushed
the
FOR-801-node-24
branch
from
d118831 to
a773424
Compare
m24murray
approved these changes
Mar 6, 2026
There was a problem hiding this comment.
Pull request overview
Updates this package to target Node.js 24 and refreshes dependencies, including small compatibility changes in formatters and test setup.
Changes:
- Bump supported/runtime Node version to 24 (CI + engines +
.nvmrc). - Upgrade runtime/dev dependencies and add npm overrides for mocha transitive deps.
- Adjust formatter/test imports and update
prettyformatter’s metadata-stripping regex for new dependency behavior.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/helper.js |
Updates sinon-chai plugin import shape for newer sinon-chai. |
package.json |
Sets Node 24 engine, upgrades deps/devDeps, adds mocha overrides. |
lib/formatters/pretty.js |
Updates sort-object-keys import, chalk instantiation, and regex handling for inspect output. |
lib/formatters/logstash.js |
Updates sort-object-keys import shape. |
.nvmrc |
Pins local Node version to 24.14.0. |
.github/workflows/ci.yaml |
Runs CI on Node 24.x only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdagnall
approved these changes
Mar 6, 2026
cmcgee4801995
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.