t4/Discretiser method str_to_state depends on predicate order, change… - #40
Open
VictorAnTe wants to merge 1 commit into
Conversation
…d also in the cartpole example and test both changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where the Discretizer method str_to_state depended heavily on predicate order, which was causing loading errors.
To fix this, a default definition for both state_to_str and str_to_state has been added directly to the base Discretizer class (affecting all discretizers generated from the pigeon class). Additionally, changes to avoid this problem in the cartpole example discretizer and testing has been added.