Fix build: vendored sample helpers, locally-built OpenCV 4.14, working Release config - #3
Open
Piero-93 wants to merge 1 commit into
Open
Fix build: vendored sample helpers, locally-built OpenCV 4.14, working Release config#3Piero-93 wants to merge 1 commit into
Piero-93 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the project build out-of-the-box (Debug and Release, x64) on a current
Visual Studio 2022 / v143 toolchain, where the original
sample_helper_includesfolder and a system-wide OpenCV 4.2 install are not available.
Changes
Build / project
$(OpenCVInstallDir)user-macro in the.vcxproj— change one value to point at your local OpenCV install.opencv_world4140d.lib/opencv_world4140.lib),replacing the hard-coded
opencv_world420d.lib/c:\opencvpaths./std:c++17(required bystd::filesystem). Both are now set.(it is not provided by the NuGet packages, unlike the Azure Kinect DLLs).
.targetsimports (silencedMSB4011warnings).Source
<...>to"..."and vendoredBodyTrackingHelpers.h/Utilities.hinto the repo root, since the upstream..\sample_helper_includesfolder is not present.#include "opencv2/calib3d.hpp"fromimage_extractor.cppandpointcloud_extractor.cpp(calib3d is never used; avoids needing that module).Repo hygiene
.gitignore: ignore the whole/.vsfolder and/k4a.k4a/headers (they are provided bythe
Microsoft.Azure.Kinect.SensorNuGet package).Docs
PREREQUISITES.mddocumenting build & runtime requirements, how to pointthe project at a local OpenCV install, and the Debug-vs-Release DLL naming.
Notes for reviewers
$(OpenCVInstallDir)(defaultC:\Temp\opencv\install). Adjust that one macro to your environment — seePREREQUISITES.md.core, imgproc, imgcodecs, highguiOpenCV modules are needed.