DT-6533 Improved navigator and local storage cooperation

[partisaani]

Proposed Changes

Navigator is now more context aware:

• If from, to, time, arriveBy and hash parameters are identical to those of the stored journey
  • Traversing to ItineraryPage detail view will automatically trigger the Navigator journey.
• If from, to, time and arriveBy parameters are identical to those of the stored journey
  • Traversing to ItineraryPage list view does not necessarily purge the stored itinerary from memory.
    • Local storage entry is purged if user navigates to list view from active navigator journey either by using the arrow icon or by browsing back using browser history
  • Traversing to ItineraryPage detail view does not purge the stored itinerary from memory, but a Navigator journey is not triggered
• If any of the parameters is different
  • Traversing to ItineraryPage list view or detail view will purge the stored Navigator journey from local storage

Pull Request Check List

• A reasonable set of unit tests is included
• Console does not show new warnings/errors
• Changes are documented or they are self explanatory
• This pull request does not have any merge conflicts
• All existing tests pass in CI build

Review

• Read and verify the code changes
• Test the functionality by running the UI locally with all popular browsers available in your platform
• Check that the implementation matches the design, when such one is defined in a Jira issue
• Merge the pull request

[vesameskanen]

Note that when you open itinerary detaul view of a bike and transit itinerary, hash is not itinerary index. It can be found from secondaryHash.

As far as I can see, we need to 'auto relaunch' navigation only in one occasion: page reloading. This is handled in useEffect [].

[partisaani]

As far as I can see, we need to 'auto relaunch' navigation only in one occasion: page reloading. This is handled in useEffect [].

Will refactor with this in mind. For possible future reference the current implementation enables the user to browse between itineraries and their detail views. Browsing to the exact same search result auto-launches Navigator.

Only explicit backtrack from an initiated journey or a change in from, to, time or arriveBy params signal to purge the stored itinerary.

[vesameskanen]

very good