Prevent user from altering the pin state of 'fixed' items as per api spec #15360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteZent
commented
Nov 9, 2024
| @@ -37,6 +37,13 @@ function isItemSuggested (officialPinnedItems, itemInfo) { | |||
| }) > -1; | |||
| } | |||
|
|
|||
| function pinIsTogglable (itemInfo) { | |||
| if (itemInfo.path === 'armoire' || itemInfo.path === 'potion' || itemInfo.type === 'debuffPotion') { | |||
There was a problem hiding this comment.
This is also referenced in the api.
Maybe this could be centralised.
API:
habitica/website/common/script/ops/pinnedGearUtils.js
Lines 147 to 149 in 573e472
ByteZent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Restrict users from pinning or unpinning items that the API does not allow to be toggled. This prevents confusion for web application users, as there is currently no feedback or message provided when such actions are attempted.
Old visual (Current live version of web client)
New visual (As per commit)
(The hover effect for the icon has also been disabled -> cursor default => not really possible to screenshot on this device)
UUID: f0c0dd64-8826-4848-a9ca-e770f4ecd17a