Skip to content

Show incomplete card names with red application banners - #188

Merged
samarth212 merged 2 commits into
mainfrom
red-step-name
Oct 11, 2026
Merged

samarth212 merged 2 commits into
mainfrom
red-step-name

Conversation

@aleczzhang

@aleczzhang aleczzhang commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Banners are now changed so it matches the incomplete card/section instead of whole page

Skipping ahead with the sidebar and coming back also counts as leaving the step, so when the user revisits that step the banner appears

Summary by CodeRabbit

  • New Features
    • Added review banners that identify incomplete items in campaign, garden, story, and contact sections when revisiting earlier steps.
    • Review messages now list the incomplete items for each section.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 23:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
seedmoney Ready Ready Preview Oct 11, 2026 6:04pm UTC

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb758643-ba18-470b-b913-7f469ab4f353

📝 Walkthrough
📝 Walkthrough

Walkthrough

The application flow now derives incomplete cards for four sections and uses their titles in review banners. The step layout tracks the furthest step reached and displays a banner for an incomplete section when the user returns to an earlier step.

Changes

Application Review Banners

Layer / File(s) Summary
Incomplete-card state and completion
src/components/application/applicationStepState.ts
getIncompleteCards returns incomplete campaign, garden, story, and contact card titles. Completion state now uses those results for the four sections.
Review-page banners
src/components/application/ReviewBanner.tsx, src/components/application/steps/ReviewStep.tsx
The review page uses the shared ReviewBanner component and formats messages from incomplete card titles for each section.
Earlier-step banners
src/app/apply/(steps)/layout.tsx
The layout tracks the furthest step reached. When the user returns to an earlier mapped section, it displays a banner if that section has incomplete cards.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Applicant
  participant StepsLayout
  participant ApplicationForm
  participant getIncompleteCards
  participant ReviewBanner
  Applicant->>StepsLayout: Navigate to an earlier section
  StepsLayout->>ApplicationForm: Subscribe to section values
  ApplicationForm-->>StepsLayout: Return section values
  StepsLayout->>getIncompleteCards: Derive incomplete titles
  getIncompleteCards-->>StepsLayout: Return incomplete cards
  StepsLayout->>ReviewBanner: Render banner when titles exist
Loading

Suggested reviewers: samarth212



Merge Risk: ⚪ Minimal · up to ad2fa

No concrete new failure remains established for the incomplete-card banners or return navigation. The PR is mergeable after normal checks.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: application banners now show incomplete card names and use red styling. It matches the changes to ReviewBanner, incomplete-card detection, and step revisi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.



✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR




🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔇 Additional comments (1)
src/components/application/applicationStepState.ts-126-126 (1)

126-126: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Validate the contact email value that the application saves.

If a user enters user@example.org , trimming makes this card complete. ReviewStep.tsx still passes the untrimmed values.contactEmail to saveContactDraft and updateCampaign. The banner clears and the submit button can enable for an address that the form has not normalized. Trim the email when writing form state, or validate the exact value used by the save paths.


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aaa0bf08-ddc1-4324-a57d-294667a7ea59
📥 Commits

Reviewing files that changed from the base of the PR and between 51f3161 and ad2faf3.

📒 Files selected for processing (4)
  • src/app/apply/(steps)/layout.tsx
  • src/components/application/ReviewBanner.tsx
  • src/components/application/applicationStepState.ts
  • src/components/application/steps/ReviewStep.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@samarth212 samarth212 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@samarth212
samarth212 merged commit 32c734c into main Oct 11, 2026
4 checks passed

This branch was successfully deployed

1 active deployment
Preview — 78671c12 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants