Repository navigation
Show incomplete card names with red application banners - #188
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No concrete new failure remains established for the incomplete-card banners or return navigation. The PR is mergeable after normal checks. Pre-merge checks |
|
There was a problem hiding this comment.
🔇 Additional comments (1)
src/components/application/applicationStepState.ts-126-126 (1)
126-126: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Validate the contact email value that the application saves.
If a user enters
user@example.org, trimming makes this card complete.ReviewStep.tsxstill passes the untrimmedvalues.contactEmailtosaveContactDraftandupdateCampaign. The banner clears and the submit button can enable for an address that the form has not normalized. Trim the email when writing form state, or validate the exact value used by the save paths.
ℹ️ Review info
⚙️ Run configuration
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
aaa0bf08-ddc1-4324-a57d-294667a7ea59
📒 Files selected for processing (4)
src/app/apply/(steps)/layout.tsxsrc/components/application/ReviewBanner.tsxsrc/components/application/applicationStepState.tssrc/components/application/steps/ReviewStep.tsx
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Banners are now changed so it matches the incomplete card/section instead of whole page
Skipping ahead with the sidebar and coming back also counts as leaving the step, so when the user revisits that step the banner appears
Summary by CodeRabbit