-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week 3 QA content #462
base: main
Are you sure you want to change the base?
Week 3 QA content #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no harm in keeping mongodb/create-employees.js
This file has a minimalistic example of how mongodb client can be used via JS.
I like the idea of giving students the boilerplate for TODO-server backend! Great addition 👍
Normalization exercises need some revision because I don't understand the rationale behind it. Perhaps if I know your vision, then I can come to appreciate it better. Let me know if you want to talk about it.
|
||
const collection = await getMongoCollection(); | ||
|
||
// http://mongodb.github.io/node-mongodb-native/3.6/tutorials/crud/#read-methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose students are supposed to fill some working code here.
I could have put in some more explanation I see 😄 I used the |
I think adding explanations for all steps makes sense because if another mentor picks up the module to teach then (s)he would want to conduct the same demonstrations as you did. And I think they are quite helpful. It would be nice if you have answer some other questions and resolve those conversations on this PR |
925773b
to
2b0fd82
Compare
restore delete mongo example change the readme
2b0fd82
to
148e91d
Compare
I removed the normalization exercise and squashed some commits from the MongoDB express server backend. |
148e91d
to
c2dddd8
Compare
I ran this QA with two exercises