fix: prevent crash when trying to msg other workers

CHANGELOG.md

@@ -6,6 +6,10 @@ SPDX-License-Identifier: AGPL-3.0-or-later
 
 # Changelog
 
+# 4.46.1
+
+Fixes crash when trying to set messages to foreign workers
+
 # 4.46.0
 
 * Adds worker messages in `api/v2/workers/messages` endpoints. Worker messages can be set by horde moderators or by their own workers and will (soon) be returned to the workers every time they pop a request as a way to send them important messages since when we don't have any other method of communication with them.

horde/apis/v2/base.py

@@ -3298,8 +3298,8 @@ def post(self):
                 raise e.WorkerNotFound(self.args.worker_id)
         if not user.moderator:
             self.origin = str(user.id)
-            if worker and worker.user_id != self.user.id:
-                raise e.Forbidden("You can only send messages to your own workers.")
+            if worker and worker.user_id != user.id:
+                raise e.Forbidden("You can only send messages to your own workers.", rc="MessagesOnlyOwnWorkers")
         self.expiry = self.args.expiry
         # Max expiry is 30 days
         if self.expiry and self.expiry > 30 * 24:

horde/exceptions.py

@@ -160,6 +160,7 @@
     "StyleGetMistmatch",
     "TooManyStyleExamples",
     "ExampleURLAlreadyInUse",
+    "MessagesOnlyOwnWorkers",
 ]