Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicAppMediaFix: support multiple (user-specified) media apps #302

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brechtm
Copy link

@brechtm brechtm commented Jun 15, 2023

Please read the commit messages for a description of the purpose of these changes.

I made these for personal use (to replace and improve upon MacMediaKeyForwarder), but if you think these are generally useful, I can update the documentation to prepare this for merging.

@mathsalmi @cmsj

The MusicAppMediaFix.mediaApps table lists the names of applications
that should receive media key events. This spoon sends the events to
the applications that was last active.
@brechtm brechtm changed the title Support multiple (user-specified) media apps MusicAppMediaFix: support multiple (user-specified) media apps Jun 15, 2023
@cmsj cmsj closed this Aug 7, 2024
@cmsj cmsj reopened this Aug 7, 2024
@@ -16,6 +17,9 @@ obj.homepage = "https://github.com/Hammerspoon/Spoons"
obj.license = "MIT - https://opensource.org/licenses/MIT"

obj.eventtap = nil
obj.appWatcher = nil
obj.mediaApps = {"Music"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really have a docstring and be notated as a Variable.

@@ -1,6 +1,7 @@
--- === MusicAppMediaFix ===
---
--- Override macOS behaviour and send all media keys (play/prev/next) to Music.app
--- Override macOS behaviour and send all media keys (play/prev/next) to
--- the last active of a specified list of apps in MusicAppMediaFix.mediaApps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove in MusicAppMediaFix.mediaApps from this docstring, given the comment below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants