Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs.hotkey: add help for setLogLevel and getLogLevel #3492

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

muescha
Copy link
Contributor

@muescha muescha commented May 22, 2023

it would be nice to have this methods visible in the documentation

maybe we add a link to hs.logger.setLogLevel and hs.logger.getLogLevel ?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@muescha muescha changed the title add help for setLogLevel and getLogLevel hs.hotkey: add help for setLogLevel and getLogLevel May 22, 2023
@muescha
Copy link
Contributor Author

muescha commented Aug 2, 2023

I don't know how to add labels... I don't see labels in the github ui... maybe I don't have a permission to add a label?

@asmagill
Copy link
Member

asmagill commented Aug 6, 2023

On the right side of this conversation, near the top, do you see little gear icons next to labels like Reviewers, Assignees, Labels, Projects, etc? I'm not sure if those options are limited or universally available...

If you do see them, click on the gear icon next to Labels and select from there... I'm guessing (without having really looked too closely at this pull) that it should be a pr-enhancement or pr-fix, but use your judgement.

If not, post here and I can add it for you.

@latenitefilms
Copy link
Contributor

Only @asmagill and @cmsj have permissions to add labels.

@asmagill
Copy link
Member

asmagill commented Aug 6, 2023

ah... ok, wasn't sure

@asmagill asmagill added docs pr-maintenance Pull Request for uninteresting maintenance work labels Aug 6, 2023
@muescha
Copy link
Contributor Author

muescha commented Sep 30, 2023

i can not see the failing test anymore :(

@cmsj cmsj merged commit 6de44c6 into Hammerspoon:master Dec 10, 2023
2 checks passed
@muescha muescha deleted the patch-1 branch February 29, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr-maintenance Pull Request for uninteresting maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants