refactor: Update dependencies #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Vue 3 bug For some unknown reason, `<TransitionGroup>` has started resetting the CSS transform on the moving progress bar if it the timer was paused while the progress bar was still transitioning. This caused the progress bar to suddenly jump to 100%. This is some weird regression when updating Vue, and I am tired of further debugging it :(
This is done by wrapping the progress bar with another div, which is unaffected by the CSS transform
Hanziness
added a commit
that referenced
this pull request
Sep 15, 2024
* refactor(deps): Update dependencies * refactor(modules): Rewrite icon generator and PWA modules into Nuxt Modules * refactor(i18n): Remove dynamic imports as all messages are compiled * refactor(components): Replace vue-tabler-icons with official package * fix(stores): Fix active schedule preset type * fix(modules): Move module output to separate .build folder * fix(settingsPanel): Fix hydration error due to class on Transition component * fix(icons): Fix icon sizes * refactor(timerProgress): Resort to different progress handling due to Vue 3 bug For some unknown reason, `<TransitionGroup>` has started resetting the CSS transform on the moving progress bar if it the timer was paused while the progress bar was still transitioning. This caused the progress bar to suddenly jump to 100%. This is some weird regression when updating Vue, and I am tired of further debugging it :( * refactor(i18n): Enable further i18n optimizations * chore(index): Remove debug print * fix(timerProgress): Fix Vue 3 `TransitionGroup` deleting CSS `transform` This is done by wrapping the progress bar with another div, which is unaffected by the CSS transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Nuxt and Vue to their latest versions. It also replaces
vue-tabler-iconswith the official@tabler/icons-vuepackage. Unfortunately, as it was my experience with every minor Nuxt (Vue) upgrade, some stuff broke this time, too. Some optimizations were also enabled invue-i18n, which should hopefully reduce the bundle size a bit.The progress bar now had an edge case due to Vue's
<TransitionGroup>resetting thetransformCSS style binding on the topmost components in thev-forlist. This only happened when there was a transition running on the progress bar - thetransformbinding simply disappeared when the timer was paused during the transition. I came across no relevant breaking changes, and thesetupfunction was also not re-run. The hack was to wrap the progress bar's movingdivwith another div, where the transform reset had no effect.