site: serve the favicon by URL so Google shows the logo in search results - #691
Merged
Merged
Conversation
…results The home page embedded its icon as a data: URI and /favicon.ico returned 404. Google only uses an icon it can fetch, so results showed a globe. Link /logo.svg, 48px and 192px PNGs and /favicon.ico instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the logo does not show next to munderdiffl.in in Google results, and the fix. Website files only.
Cause
data:URI. Google only uses an icon it can fetch by URL.https://munderdiffl.in/favicon.icoreturned 404.Change
docs/index.html: the embedded icon is replaced by links to/logo.svg,/favicon-48.png,/favicon-192.png,/favicon.icoand/apple-touch-icon.png.docs/favicon-48.png,docs/favicon-192.png(Google asks for a multiple of 48px) anddocs/favicon.ico, all made from the existingdocs/logo.png.After merge
Google picks up a favicon on its next crawl of the home page, which can take days to a few weeks. I will request a recrawl of the home page in Search Console.
Before
After
🤖 Generated with Claude Code