Repository navigation
Conversation
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
This is exactly what we are looking for out of these changes. Good work. Some small change requests but generally looking good
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
|
just addressing build issues and not addressing any feedback. trying to not step on your toes Nenne. :) I'm trying a new script to be able to preview a pr build locally. |
edf7053 to
48919df
Compare
heskew
left a comment
heskew
left a comment
There was a problem hiding this comment.
Didn't follow the steps but it looks good reading through. Looking good @nenharper 👍
|
This is introducing a number of unrelated changes now. Lets revert that and just have this PR be content related. Thank you! |
edbcc02 to
84b7385
Compare
|
yep. sorry @nenharper for messing with your pr. I'm pulling out the unrelated changes I added while the build was broken. unwinding the changes required a force push so you might need to delete your local branch and do a fresh pull and check out. real sorry for messing with your workflow. :-/ |
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
Okay I think this is good to go as soon as the new changes are copied to docs/ and 4.5
This PR makes the data loader page more narrative and adds a corresponding reference page for dataloader