Skip to content

Fix: Add read_log log_name attr - #353

Merged
Ethan-Arrowood merged 2 commits into
mainfrom
fix/read_log-log_name-attr-missing
Oct 22, 2025
Merged

Ethan-Arrowood merged 2 commits into
mainfrom
fix/read_log-log_name-attr-missing

Conversation

@cap10morgan

Copy link
Copy Markdown
Contributor

This has been an optional attribute since forever, but was missing from the docs.

@cap10morgan
cap10morgan requested a review from a team October 15, 2025 17:00

@kriszyp kriszyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder if we really want to document this; we don't have clustering stuff anymore and we have been working on increasingly trying to hide/abstract anything to do with the filesystem. I suppose we could include and just say it is only supports hdb.log. We also should change the implementation so that parent directory referencing is restricted/prevented.

@cap10morgan

Copy link
Copy Markdown
Contributor Author

Should we just deprecate it instead? And then ignore it if set and only over send back hdb.log from this op?

@kriszyp

kriszyp commented Oct 16, 2025

Copy link
Copy Markdown
Member

But we recently added the ability to have distinct log files for different components. So it actually is kinda useful again.

@cap10morgan

Copy link
Copy Markdown
Contributor Author

But we recently added the ability to have distinct log files for different components. So it actually is kinda useful again.

So maybe change it to something like component and have it default to harper (or similar) when omitted?

@Ethan-Arrowood
Ethan-Arrowood merged commit 84b5d9e into main Oct 22, 2025
5 checks passed
@Ethan-Arrowood
Ethan-Arrowood deleted the fix/read_log-log_name-attr-missing branch October 22, 2025 20:53
Ethan-Arrowood added a commit that referenced this pull request Oct 22, 2025
Ethan-Arrowood added a commit that referenced this pull request Oct 22, 2025
@Ethan-Arrowood
Ethan-Arrowood restored the fix/read_log-log_name-attr-missing branch October 22, 2025 20:59
@Ethan-Arrowood
Ethan-Arrowood deleted the fix/read_log-log_name-attr-missing branch January 14, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants