Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation across several files to reflect the new behaviors introduced in version 5.4.0, specifically regarding isolated applications, worker restarts, branched database forks, and the drop_component API. The feedback recommends avoiding the use of the <VersionBadge> component at the start of a paragraph in running prose within reference/components/applications.md to maintain a clean reading flow.
| <VersionBadge version="v5.4.0" /> | ||
|
|
||
| The response reports this node's outcome, and each peer's in `replicated`: |
There was a problem hiding this comment.
Avoid using the <VersionBadge> component at the start of a paragraph in running prose. Instead, use plain text (e.g., 'As of v5.4.0') to maintain a clean and consistent reading flow, reserving <VersionBadge> for standalone placement directly under headings.
| <VersionBadge version="v5.4.0" /> | |
| The response reports this node's outcome, and each peer's in `replicated`: | |
| As of v5.4.0, the response reports this node's outcome, and each peer's in `replicated`: |
References
- Avoid using the component at the start of a paragraph in running prose. Use plain text (e.g., 'As of vX.Y.Z') instead, reserving for standalone placement after headings.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-750 This preview will update automatically when you push new commits. |
… results For HarperFast/harper#3339 (v5.4.0): a new isolated application's first restart deploy starts only its own worker, as its canary; drop_component stops an isolated application's worker with or without restart, removes its forks by default (keepBranches keeps them), restarts nothing on a node that does not have the application, and reports each node's outcome. Adds the one-call preview cleanup for clusters on v5.4.0, and a 5.4 release note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gDmwTaExpc8uXcdBNr8eA Dispatch-Task: harper-3045 Dispatch-Task: documentation-750-rebase Co-Authored-By: GPT-5 Codex <noreply@openai.com>
… check every node's outcome Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gDmwTaExpc8uXcdBNr8eA Dispatch-Task: harper-3045 Dispatch-Task: documentation-750-rebase Co-Authored-By: GPT-5 Codex <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gDmwTaExpc8uXcdBNr8eA Dispatch-Task: harper-3045 Dispatch-Task: documentation-750-rebase Co-Authored-By: GPT-5 Codex <noreply@openai.com>
…hen the shared workers restart Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gDmwTaExpc8uXcdBNr8eA Dispatch-Task: harper-3045 Dispatch-Task: documentation-750-rebase Co-Authored-By: GPT-5 Codex <noreply@openai.com>
…e the issue that set log-only removal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gDmwTaExpc8uXcdBNr8eA Dispatch-Task: harper-3045 Dispatch-Task: documentation-750-rebase Co-Authored-By: GPT-5 Codex <noreply@openai.com>
37fb942 to
88db998
Compare
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-750 This preview will update automatically when you push new commits. |
📝 Summary
Documents Start and stop one isolated application without restarting the shared workers (harper#3339), which ships in v5.4.0:
restart=truedeploy starts only its own worker, and that worker is the release's canary.restart.drop_componentremoves the application's forks by default;keepBranches: truekeeps them but fails withrestart: true. A node that does not have the application restarts nothing.node,componentRemoved,workerStoppedandbranchesRemoved, with each peer's outcome inreplicated.🔧 Changes
reference/components/applications.md: Restarting and dropping, the Durable fork bullet, Removing a fork (default removal, when forks stay,keepBranches, the early-answer exception tracked in harper#3463), anddrop_component'skeepBranchesfield and response.reference/operations-api/operations.md: deploy restart scope, drop timing and scope, an isolated application's canary, and the canaryunavailablerow.learn/developers/deploying-from-ci.mdx: before/after notes, the per-node recipe marked as pre-v5.4.0, and Cleanup in one call on v5.4.0.learn/developers/multiple-applications.mdx: when a fork is removed.release-notes/v5-lincoln/5.4.md: Starting and Stopping One Isolated Application.✅ Verification
dropApplication,dropPeerResultsand the deploy restart scope incomponents/operations.js, thekeepBranchesvalidator, and harper-pro's peer answer path for thereplicatedshape.npm run format:write,npm run format:check,npm run build,npm run typecheck,npm run lint,npm run test:workflows, andnpm run test:examplespass. The local cross-repository fixture comparison is skipped by default; there are no broken links or anchors.Review follow-up on existing content
The rebase preserves the prior PR content. Its own review should qualify certification for linked directories, date the earlier preview restart cross-reference, and distinguish single-file restart from application shutdown. The one-call cleanup intentionally trusts the Operations API's completed response; worker-originated early answers use a different route. Release-tag and runtime verification remain deferred below.
Depends-on: HarperFast/harper#3339
🤖 Generated by Anthropic Claude and OpenAI Codex; posted via @kriszyp.
Related PRs: #751 overlaps, #671 overlaps
Complexity: easy
Deferred findings
c8efa0c731826211nit documentation —reference/components/applications.md— v5.4.0 behavior claims not verified against the shipped v5.4.0 tag — NOT FILEDReview-Coverage: authored=codex; ran=gemini,cursor-composer,cursor-grok; late=cursor-grok:adjudicated; adjudicated=domain; declined=muse,claude; rounds=6; full=1 @ 88db998
Review-Attention: read ~3m (decisions: cleanup-evidence; raised: degraded review) @ 88db998