Fix malformed workspace Git metadata handling - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes malformed Git metadata handling in workspace scans on the current
mainimplementation.Before this change, an embedded NUL in a linked-worktree
.gitgitdir pointer, gitdir backpointer, orcommondirvalue could raise during path resolution before the CLI emitted a workspace matrix. The CLI exited non-zero, but it printed a traceback instead of returning structured JSON.The metadata path handling now rejects control characters before resolving paths and treats
ValueErrorlike other unreadable metadata failures. This preserves the existing linked-worktree authenticity checks onmain, including gitdir backpointer validation and commonworktreesparent validation. Malformed metadata is reported throughcoverage.diagnosticsasUNVERIFIABLE, while healthy linked worktrees continue to scan normally.Validation:
python -m pytest -q tests/test_workspace.pypython -m pytest -q.git, gitdir backpointer, andcommondirmetadata: exit 1, JSON stdout,workspace_status: UNVERIFIABLE, empty stderr, and no raw control-character path fragmentsMATCHrepositorygit diff --cached --check -- src/public_surface_sweeper/workspace.py tests/test_workspace.py