# the TIBX prototype writer silently truncated files and replaced bad UUIDs - #402
Merged
Merged
Conversation
Hawkynt
force-pushed
the
fix/acronis-tibx-writer-data-loss
branch
from
September 30, 2026 12:09
46a42d1 to
fa55922
Compare
Hawkynt
force-pushed
the
fix/acronis-tibx-writer-data-loss
branch
2 times, most recently
from
September 30, 2026 16:07
de55887 to
381b6d5
Compare
… UUIDs AcronisTibxWriter.Build stores each file in a single DATA page. Content longer than that page was cut to 4076 bytes with no error, and an archive UUID of the wrong length was quietly swapped for a random one. Build now checks its inputs first. A file larger than the new MaximumFileContentLength is refused with NotSupportedException, and so is a UUID that is not 16 bytes (ArgumentException). Accepted content is copied in full. Boundary tests cover exactly the maximum, one byte past it, and a 15-byte UUID. The writer is still an unadvertised structural prototype and CanCreate stays off. The earlier branch's REFERENCE.md regeneration deleted about 44k lines. It was dropped and the file regenerated from main's.
Hawkynt
force-pushed
the
fix/acronis-tibx-writer-data-loss
branch
from
September 30, 2026 18:04
fc49fec to
cef4f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The existing reader-inverting TIBX prototype stored file content in one DATA page but silently truncated content larger than that page. It also silently generated a replacement UUID when a caller supplied an invalid-length UUID.
This change validates file inputs up front, exposes the maximum supported single-page payload, rejects oversized files and malformed UUIDs, and copies the full content for all accepted sizes. Tests cover the exact payload boundary and both rejection cases.
Scope
Acronis documents TIBX as its version 12 backup-chain format, but does not publish the LSM writer format. The existing writer remains an unadvertised structural prototype; this PR does not claim vendor-restorable backup creation. Full multi-page data mapping and metadata-preserving creation require the proprietary LSM/index and extent structures.
References
acronis-tib-readerused only as a behavioral/format reference; no implementation code copied: https://github.com/TreadingTheTiber/acronis-tib-readerValidation
git diff --checkpassed.dotnetis not installed.