Skip to content

# the TIBX prototype writer silently truncated files and replaced bad UUIDs - #402

Merged
Hawkynt merged 1 commit into
mainfrom
fix/acronis-tibx-writer-data-loss
Sep 30, 2026
Merged

Hawkynt merged 1 commit into
mainfrom
fix/acronis-tibx-writer-data-loss

Conversation

@Hawkynt

@Hawkynt Hawkynt commented Sep 29, 2026

Copy link
Copy Markdown
Owner

What changed

The existing reader-inverting TIBX prototype stored file content in one DATA page but silently truncated content larger than that page. It also silently generated a replacement UUID when a caller supplied an invalid-length UUID.

This change validates file inputs up front, exposes the maximum supported single-page payload, rejects oversized files and malformed UUIDs, and copies the full content for all accepted sizes. Tests cover the exact payload boundary and both rejection cases.

Scope

Acronis documents TIBX as its version 12 backup-chain format, but does not publish the LSM writer format. The existing writer remains an unadvertised structural prototype; this PR does not claim vendor-restorable backup creation. Full multi-page data mapping and metadata-preserving creation require the proprietary LSM/index and extent structures.

References

Validation

  • git diff --check passed.
  • .NET tests could not be run in this environment because dotnet is not installed.

@Hawkynt
Hawkynt force-pushed the fix/acronis-tibx-writer-data-loss branch from 46a42d1 to fa55922 Compare September 30, 2026 12:09
@Hawkynt Hawkynt changed the title Reject lossy inputs in the TIBX prototype writer # the TIBX prototype writer silently truncated files and replaced bad UUIDs Sep 30, 2026
@Hawkynt
Hawkynt force-pushed the fix/acronis-tibx-writer-data-loss branch 2 times, most recently from de55887 to 381b6d5 Compare September 30, 2026 16:07
… UUIDs

AcronisTibxWriter.Build stores each file in a single DATA page. Content
longer than that page was cut to 4076 bytes with no error, and an
archive UUID of the wrong length was quietly swapped for a random one.

Build now checks its inputs first. A file larger than the new
MaximumFileContentLength is refused with NotSupportedException, and so
is a UUID that is not 16 bytes (ArgumentException). Accepted content is
copied in full. Boundary tests cover exactly the maximum, one byte past
it, and a 15-byte UUID.

The writer is still an unadvertised structural prototype and CanCreate
stays off. The earlier branch's REFERENCE.md regeneration deleted about
44k lines. It was dropped and the file regenerated from main's.
@Hawkynt
Hawkynt force-pushed the fix/acronis-tibx-writer-data-loss branch from fc49fec to cef4f43 Compare September 30, 2026 18:04
@Hawkynt
Hawkynt merged commit ebcf31c into main Sep 30, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant