Skip to content

Conversation

DleanJeans
Copy link

For issue #61
This passes all the tests I wrote over DleanJeans/hscript-plus.
Let me know if there's something wrong!

@ncannasse
Copy link
Member

Could you add some unit tests for it in Test.hx?

@DleanJeans
Copy link
Author

I ran into a problem with string interpolation inside another ('${'string'}'). I'll need to modify Parser::readString() and it's gonna take a while. Would you mind helping me by explaining how string interpolation exactly works in Haxe itself?

@Simn
Copy link
Member

Simn commented May 7, 2017

Do we really want this in hscript? String interpolation is an order of magnitude more complex than everything else, especially when it starts being nested. We haven't even solved that in the compiler properly.

@DleanJeans
Copy link
Author

I guess I'll just leave it unsolved.

@DleanJeans DleanJeans force-pushed the string-interpolation branch from b92e8a8 to 9b53b4b Compare May 7, 2017 16:01
@DleanJeans
Copy link
Author

Will this be merged any time soon? If not, at least I can leave it as a feature in my hscript-plus.

@ncannasse
Copy link
Member

Unless it's well tested and compliant with Haxe I think it shouldn't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants