Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode mOutPre in Manifester #1193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ACrazyTown
Copy link

Commit 01ef3fa#diff-740d630a82410c3a632c1c2894824c904ce81e2750fd946396c3187df271e1c5L1154-L1155 changed some things around and stopped parsing mOutPre and mOutPost from the toolchain xml which was causing build issues due to a missing argument:
image

Since mOutPost was hardcoded to begin with, this is a little patch to do the same for mOutPre and prevent build errors.

@tobil4sk
Copy link
Member

Commit 01ef3fa#diff-740d630a82410c3a632c1c2894824c904ce81e2750fd946396c3187df271e1c5L1154-L1155 changed some things around and stopped parsing mOutPre and mOutPost from the toolchain xml which was causing build issues due to a missing argument:

The commit message doesn't mention their removal or why it was done, I wonder if it should have been removed at all.

@ACrazyTown
Copy link
Author

The commit message doesn't mention their removal or why it was done, I wonder if it should have been removed at all.

Might have been an oversight, as the field is now never set. If needed I can revert my change and bring back the previous code

Ideally this should get merged asap as currently trying to add a manifest will always result in a build failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants