Adding python wheels for the package and for the kernels#17
Open
michaelfeil wants to merge 9 commits intoHazyResearch:mainfrom
Open
Adding python wheels for the package and for the kernels#17michaelfeil wants to merge 9 commits intoHazyResearch:mainfrom
michaelfeil wants to merge 9 commits intoHazyResearch:mainfrom
Conversation
Author
|
This can be merged FYI |
Contributor
|
Thanks so much for this PR, it looks really helpful. Two requests:
|
Author
|
Contributor
|
I don't think I can squash it, since it's a PR from your branch. I'm not an expert in github's online interfaces though :) For the tests - I mean can we run the unit tests just once before merging them in to validate. (if you can run them and share a screenshot of the results that is good too) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, you can click Release, and create a tag that starts of with wheels*, e.g. wheels-0.0.1. The wheel is created for each torch major and cuda version, I would recommend getting the right build from the right matrix.
Background: The CudaExtensions takes decent time in CI to build, I prefer to pin some version from the github release, over a
clone + pip install -e .Pipeline should be roughly reusable. I built it partially from scratch, partially from Autoawq. Its running under MIT Licence.
Cheers
Michael feil