Repository navigation
Conversation
cursorIndex and selectionRange count the EXPANDED text - the text with the line breaks word wrapping inserted, as getTextPos's documentation says - and every operation on the text itself converts through getTextPos first. Ctrl+C and Ctrl+X did not: they took `text.substr(selectionRange.start, selectionRange.length)` straight from the text, so on any wrapped line the clipboard was given a copy shifted by one character per wrap above the selection, while cutSelection removed the correct characters. Cutting a word and pasting it back therefore lost a letter. getSelectedText already does the conversion, so both now use it. getWordEnd had the mirror of the same confusion: `ret` is a position in the text, but it was bounded by getTextLength(), which is the expanded length and so longer than the text by one per inserted break. A double-click on a word at the end of a wrapped text selected one character past the end of it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cursorIndexandselectionRangecount the expanded text (with the line breaks word wrapping inserts, asgetTextPosdocuments), and every operation on the text converts throughgetTextPosfirst, except two:text.substr(selectionRange.start, selectionRange.length)directly, so on wrapped text the clipboard got a copy shifted by one character per wrap above the selection, whilecutSelectionremoved the correct characters. Cutting a word and pasting it back lost a letter. Both now usegetSelectedText(), which already does the conversion.getWordEndbounded a text position (ret) bygetTextLength(), the expanded length. Double-clicking the last word of a wrapped text selected one character past its end. It now bounds bytext.length.Single-line inputs are unaffected, since expanded and raw positions are the same there.