Repository navigation
Conversation
When a break char already overflows maxWidth, lastBreak is set to i - 1, which can point before the start of the current line (lastPos - 1). The rewind branch then flushes an empty line without advancing i or lastPos, and the loop repeats forever. This happens e.g. with maxWidth = 0 (layouts that measure at zero width first) and CJK text, or TextInput with trimTrailingSpaces = false. Only rewind to a break point inside the current line, so every rewind consumes at least one character. lastPos is never negative, so this still implies the old lastBreak >= 0 check. Fixes HeapsIO#1347 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text: fix splitRawText infinite loop when wrap width is below one glyph
Fixes HeapsIO/heaps#1347 (repro attached there).
When a break char already overflows maxWidth, lastBreak is set to i - 1, which can point before the current line start. The rewind then flushes an empty line without advancing i/lastPos, looping forever. This is triggered by e.g. layouts that measure at width 0 first (HaxeUI, Flow constraints), CJK text, or TextInput (trimTrailingSpaces = false).
Requiring lastBreak >= lastPos guarantees each rewind consumes at least one char. It still implies the old lastBreak >= 0 check, and wrapping output at normal widths is unchanged.