Skip to content

Fix multiple issues (#58, #68, #89, #92)#168

Merged
AbelOsaretin merged 1 commit into
Heliobond:mainfrom
archanavdev:fix-issues-58-68-89-92
Jun 30, 2026
Merged

Fix multiple issues (#58, #68, #89, #92)#168
AbelOsaretin merged 1 commit into
Heliobond:mainfrom
archanavdev:fix-issues-58-68-89-92

Conversation

@archanavdev

Copy link
Copy Markdown
Contributor

Description

This PR resolves multiple outstanding documentation, architecture, and testing issues across the repository in a single branch.

Key Changes:

  • Testing: Introduced wasm_test modules into project_registry and investment_vault utilizing sha2 to hash and verify the generated WASM outputs.
  • Architecture: Separated storage access and core business logic by introducing storage.rs and logic.rs modules in both contracts, paving the way for a more maintainable, decoupled codebase.
  • Documentation:
    • Added a comprehensive API.md detailing the function signatures, return values, errors, and common usage examples for both smart contracts.
    • Expanded SECURITY.md to document our threat model, cross-contract trust assumptions, known limitations, and standard incident response protocols.

Related Issues

Closes #58
Closes #68
Closes #89
Closes #92

Testing

  • cargo test --workspace passes successfully.
  • Verified that new documentation markdown renders correctly.
  • WASM snapshot tests correctly compile and capture expected build hashes.

…ond#92)

- Add snapshot testing for WASM outputs
- Implement logic and storage separation pattern
- Add comprehensive API.md
- Expand SECURITY.md threat model
@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@archanavdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@AbelOsaretin AbelOsaretin merged commit 0f6cbb4 into Heliobond:main Jun 30, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants