Fix multiple issues (#58, #68, #89, #92)#168
Merged
Merged
Conversation
…ond#92) - Add snapshot testing for WASM outputs - Implement logic and storage separation pattern - Add comprehensive API.md - Expand SECURITY.md threat model
|
@archanavdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves multiple outstanding documentation, architecture, and testing issues across the repository in a single branch.
Key Changes:
wasm_testmodules intoproject_registryandinvestment_vaultutilizingsha2to hash and verify the generated WASM outputs.storage.rsandlogic.rsmodules in both contracts, paving the way for a more maintainable, decoupled codebase.API.mddetailing the function signatures, return values, errors, and common usage examples for both smart contracts.SECURITY.mdto document our threat model, cross-contract trust assumptions, known limitations, and standard incident response protocols.Related Issues
Closes #58
Closes #68
Closes #89
Closes #92
Testing
cargo test --workspacepasses successfully.