Map font sizes to type scale, share icons, extract shell CSS, validat…#180
Merged
Merged
Conversation
…e funding goal Addresses four design-system cleanup issues: Heliobond#87 Type scale: replace ad-hoc inline font sizes (12.5, 14.5, 30, …) with a single documented ladder of var(--type-*) tokens. Expands tokens/typography.css with the missing rungs (micro/fine, body-lg, h1–h5, h3-sm, data-xl) and snaps off-scale values to the nearest rung. Every fixed fontSize in components/screens now references a token; bespoke fluid clamp() display sizes are left as-is. Heliobond#83 Styling approach: add src/styles/shell.css plus src/styles/README.md documenting the hb- class + var(--token) convention. Migrate the shell — TopBar (incl. the wallet menu) and Footer — off inline-style objects onto classes, with hover/active/focus expressed in CSS (:hover, [aria-current]) instead of JS state. Heliobond#92 Icons: add src/components/icons.tsx as the single home for shared stroke icons and reuse them — the duplicated location pin (ProjectCard + ProjectDetail), the shell's Sun/Moon/Chevron, ShieldCheck, AddressChip's Copy/Check/External, Toast's Close, ProjectBuilder's Upload, and CreatorApplication's check badge. Heliobond#109 Funding goal: sanitize the ProjectBuilder goal input to digits + a single decimal point and validate it. Empty, non-numeric, or non-positive goals are now explained inline (aria-invalid + role="alert") instead of silently showing "$0 of $0".
|
@nonso7 is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nonso7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…commit hook The CI workflow (build → typecheck → lint → format) was red on pre-existing issues unrelated to the design-system work. This makes all four steps green. - i18n (typecheck): messages/en.json had drifted out of sync with fr.json — ProjectDetail used stale keys, the Admin namespace was missing entirely, and Creator was reduced to two keys. Since the default locale is English, this also broke the live English UI. Both catalogs are now structurally identical (279 keys each); English text authored for ProjectDetail, Admin, and Creator, and the Creator title/description the page uses added to fr.json. - lint: AmountInput no longer reads/writes a ref during render — the cap message is derived directly (the aria-live region already throttles announcements to content changes). CreatorApplication's dynamic next-intl keys use `as Parameters<typeof t>[0]` instead of `as any`. - pre-commit hook: lint-staged fed staged filenames to `tsc`, tripping TS5112 on every .tsx commit; wrap the typecheck so the project tsconfig is used. - format: prettier-clean the files flagged by `format:check`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e funding goal
Addresses four design-system cleanup issues:
#87 Type scale: replace ad-hoc inline font sizes (12.5, 14.5, 30, …) with a single documented ladder of var(--type-*) tokens. Expands tokens/typography.css with the missing rungs (micro/fine, body-lg, h1–h5, h3-sm, data-xl) and snaps off-scale values to the nearest rung. Every fixed fontSize in components/screens now references a token; bespoke fluid clamp() display sizes are left as-is.
#83 Styling approach: add src/styles/shell.css plus src/styles/README.md documenting the hb- class + var(--token) convention. Migrate the shell — TopBar (incl. the wallet menu) and Footer — off inline-style objects onto classes, with hover/active/focus expressed in CSS (:hover, [aria-current]) instead of JS state.
#92 Icons: add src/components/icons.tsx as the single home for shared stroke icons and reuse them — the duplicated location pin (ProjectCard + ProjectDetail), the shell's Sun/Moon/Chevron, ShieldCheck, AddressChip's Copy/Check/External, Toast's Close, ProjectBuilder's Upload, and CreatorApplication's check badge.
#109 Funding goal: sanitize the ProjectBuilder goal input to digits + a single decimal point and validate it. Empty, non-numeric, or non-positive goals are now explained inline (aria-invalid + role="alert") instead of silently showing "$0 of $0".
Summary
Linked issue
Closes #
Type of change
Screenshots / screencast
Checklist
Closes #…)bun run buildpasses locally (builds + type-checks)messages/en.jsonandmessages/fr.json(if any copy changed)Closes #87
Closes #83
Closes #109
Closes #92