Skip to content

fix(#71): announce theme toggle state#185

Merged
sshdopey merged 2 commits into
Heliobond:mainfrom
edehvictor:fix/theme-toggle-state-71
Jun 30, 2026
Merged

fix(#71): announce theme toggle state#185
sshdopey merged 2 commits into
Heliobond:mainfrom
edehvictor:fix/theme-toggle-state-71

Conversation

@edehvictor

@edehvictor edehvictor commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose the theme toggle state with �ria-pressed so screen readers can tell when dark mode is active
  • keep the existing action label, but derive it from the resolved mounted theme state used by the toggle icon
  • add focused TopBar coverage for the dark and light theme toggle announcements

Closes #71
Closes #67
Closes #63
Closes #56

Type of change

  • Bug fix
  • Feature
  • Localization (i18n)
  • Accessibility
  • Smart contract / on-chain wiring
  • Docs / chore

Screenshots / screencast

No visible UI change beyond accessibility semantics.

Checklist

  • Tied to an accepted issue (Closes Announce theme toggle state #71)
  • �un run build passes locally (builds + type-checks)
  • Follows the design system — no layout or copy changes
  • User-facing strings added to both messages/en.json and messages/fr.json (not needed)
  • Accessible — the theme toggle now exposes pressed state
  • No secrets committed
  • Docs updated where relevant (not needed)

Testing

Not run locally.

@edehvictor edehvictor requested a review from dadadave80 as a code owner June 30, 2026 07:16
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@edehvictor is attempting to deploy a commit to the David Dada's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@edehvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@sshdopey sshdopey merged commit 527f431 into Heliobond:main Jun 30, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants