Skip to content

test: add unit tests for ScoreGauge, message parity, CreatorApplication, and ProjectDetailPage (#22, #28, #29, #30)#187

Merged
sshdopey merged 4 commits into
Heliobond:mainfrom
devonahi:main
Jul 3, 2026
Merged

test: add unit tests for ScoreGauge, message parity, CreatorApplication, and ProjectDetailPage (#22, #28, #29, #30)#187
sshdopey merged 4 commits into
Heliobond:mainfrom
devonahi:main

Conversation

@devonahi

Copy link
Copy Markdown
Contributor

Adds test coverage for four open-source issues and fixes related bugs discovered during testing.
Changes by issue
Closes #22 — ScoreGauge arc geometry and clamping

  • Added src/components/ScoreGauge.test.tsx (8 tests)
  • Tests fraction clamping for negative values and values above max
  • Asserts dot position stays on the arc for 0, max, and out-of-range values
    Closes Add a message-catalog parity test #28 — Message-catalog parity test
  • Added src/tests/catalog-parity.test.ts (1 test)
  • Recursively asserts messages/en.json and messages/fr.json have identical leaf key sets
  • Removed duplicate ProjectDetail blocks in both catalogs and aligned cross-catalog keys
    Closes Add CreatorApplication form validation tests #29 — CreatorApplication form validation tests
  • Added src/screens/creator/CreatorApplication.test.tsx (7 tests)
  • Tests canSubmit gating: disabled when fields empty, whitespace-only, or partially filled
  • Tests stage advancement from submitted to in review after submit
  • Bug fix: Fixed PascalCase translation key generation in Stepper for underscored stage IDs (in_review → stepInReviewLabel)
    Closes Add a ProjectDetailPage not-found test #30 — ProjectDetailPage not-found test
  • Added src/app/project/[id]/page.test.tsx (3 tests)
  • Asserts unknown/non-numeric ids render the not-found view
  • Asserts known ids render the project detail (via mocked ProjectDetail screen)
  • Covers loading skeleton state

devonahi added 4 commits June 30, 2026 16:38
Recursively assert en.json and fr.json have identical leaf key sets.
Remove duplicate ProjectDetail blocks and align cross-catalog keys.
Fix PascalCase translation key generation in Stepper for underscored
stage IDs. Cover canSubmit gating and stage advancement on submit.
Assert unknown/non-numeric ids render the not-found view and known
ids render the project detail. Cover loading skeleton state.
@devonahi devonahi requested a review from dadadave80 as a code owner June 30, 2026 15:47
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@devonahi is attempting to deploy a commit to the David Dada's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@devonahi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@sshdopey sshdopey merged commit c65d9f0 into Heliobond:main Jul 3, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants