created quests for lgbtq people

[jan-leila]

Leaving as a draft for now because I dont have any icons for things yet and im waiting for some friends to translate some of the text for me, but other then that PR is almost ready to go

Added:

• Quest to label if there is signage on a places relation to LGBTQ people
• Quest to specify what that relation is
• Quest to label if a lgbtq ~ primary|only venue targets a specific gender
• Quest to label if a lgbtq ~ primary|only venue targets specifically transgender people

Still needed:

• icons
• translations

relevant wiki page: https://wiki.openstreetmap.org/wiki/Key:lgbtq

[Helium314]

lgbtq:signed does not have any uses according to taginfo.
I would prefer merging the access and the signed quests, so the access quest would just allow a not signed answer.

[jan-leila]

as far as I can tell there isnt really any used tag that could be used to mark the quest as completed if a place just has nothing posted

[jan-leila]

also the other goal with separating out the quests like that was to hide the complexity of picking what kind of signage behind the knowledge of their actually being signage

[jan-leila]

and also a "no" on the signage does not mean the place is in that neutral state it just means its not apparent when you walk by, I wouldn't want places that on their website say they are lgbtq=primary but dont have any sings displaying that in person getting marked at the neutral state

[Helium314]

as far as I can tell there isnt really any used tag that could be used to mark the quest as completed if a place just has nothing posted

SCEE guidelines are more loose than for SC, there are already several quests that don't fulfill no unanswerable quests.

also the other goal with separating out the quests like that was to hide the complexity of picking what kind of signage behind the knowledge of their actually being signage

With the downside of pushing a completely new tag exclusively via SCEE.
Also that tag likely doesn't fulfill the only guideline that is still strict as it does also affect non-users (no spam).

[jan-leila]

SCEE guidelines are more loose than for SC, there are already several quests that don't fulfill no unanswerable quests.

gotcha, ill remove it then, do you have a example you can point me to on how we go about hiding the quest locally when there isnt a clear answer?

[Helium314]

do you have a example you can point me to on how we go about hiding the quest locally when there isnt a clear answer?

Either you use other answers -> can't say -> hide, or use the quick hide button that can be enabled in Settings / UI, or if you want to bake it into the quest you can add some UI element or other answer that calls osmQuestController.hide(questKey as OsmQuestKey) (get the controller using private val osmQuestController: OsmQuestController by inject()

[Helium314]

I guess putting it into the form makes most sense, as (around here) it would be the most common answer.
Unfortunately hiding is a rather bad thing when hiding is the "answer" most of the time, as it means the quest will still be shown to other users... but given that SCEE only has ~500 active users (see here), there is hope that 2 users in the same area is a rather rare thing.

[mnalis]

Unfortunately hiding is a rather bad thing when hiding is the "answer" most of the time

Yeah, quests with that issue that becomes very tedious very fast in my experience (usually resulting in me disabling the quest in most of my presets). For things where majority of answers are "not signed", perhaps an SCEE Overlay might be better solution than the Quest? That would seem to address that very problem.

(Relatedly, also people might be interested in creating LGBTQ+ theme for https://mapcomplete.org/ as that creates both a browseable map and a specialized quest; somewhat similar to how SC(EE) Overlays work, but available in regular desktop&mobile browsers)

[Helium314]

Another way would be using a server (but considerably more work for setting up the server). E.g. Osmose quests are "hidden" for everyone when you answer it's a false positive.

[Helium314]

I'd like to summarize what is still to be done here

• icons
• maybe don't use Enbys, I only understood the meaning from the string name quest_lgbtq_gender_specialization_non_binary (but no change required)
• don't tag whether it's signed, see above
  • maybe allow hiding the quest directly
  • or maybe tie element selection to a web service similar to osmose (but that's a lot of work)

Anything else?
Translations are mentioned, but can be done later with Weblate.

[jan-leila]

Okay I think besides icons and translations things are good on my end, not sure what to do about those two items though being im only a native English speaker and am not good with design software

[jan-leila]

icons needed are as follows:

LGBTQ access quest icon for pin on map
LGBTQ access quest banned icon
LGBTQ access quest welcome icon
LGBTQ access quest primary icon
LGBTQ access quest only icon
LGBTQ access quest unknown icon

LGBTQ Gender Specialization Quest icon for pin on map

LGBTQ Transgender Specialization Quest icon for pin on map

[Helium314]

LGBTQ access quest banned icon
LGBTQ access quest welcome icon
LGBTQ access quest primary icon
LGBTQ access quest only icon
LGBTQ access quest unknown icon

You could avoid those by using a AListQuestForm like the seating quest

Some possibly dull but working idea would be use the common flag colors (rainbow / transgender) for the specialization quests, maybe with some additional icon.
The access quest could use something like https://wiki.openstreetmap.org/wiki/File:AllPeopleSticker.jpg

Okay I think besides icons and translations things are good

Translations are not needed, they will be added by other users using Weblate.

btw tempHide does only hide the quest until the next change of the element, or until the surrounding area is cleared from cache. A "normal" hide seems more appropriate to me.

[jan-leila]

I considered using a list form but I would like to have the examples, but maybe sort term here just to get the feature existing I use a list form and we can work on getting the other icons together some other time. (Ill switch it if we get the icons for everything else made first)

and ill switch the temp hide

[Helium314]

Looks like you have some icons now. I think the only thing missing are the icons you wanted for the access quest, or is there anything else?

[jan-leila]

nope that's it, I'll go and make a commit to just make the access quests text only for now sometime in the next few days here

[mscherer]

Look good to me, besides some nitpicking and unfortunately, a update on the list of unsafe place :/

I am quite sure I am forgetting a country where some BS propaganda law was passed or proposed not so long ago, but

[Helium314]

I also only have a few minor things to add:

• The new quests should also be disabled by default, same as other SCEE quests. You can just add the generic SCEE message: override val defaultDisabledMessage = R.string.default_disabled_msg_ee.
• Answers (for the access form) should start with an uppercase letter to be consistent with other quests.
• Would it be ok to have the not posted / hide forever answer in the "normal" list of answers for the access quest? It's a bit tricky to implement, so I would do it myself (maybe a little later though).

[jan-leila]

Hey @Helium314 I updated the branch here with the changes you recommended sans the not posted /hide forever answer because I am not quite sure how to implement it in the given API. I think this is ready for review again/merge if you would like to take a look at it. I would tag you on the reviews but its not giving me the option to tag you for some reason?
Thanks for your time.

[mnalis]

(Also, just a quick note that merging of SCEE PRs is on temporary hold, while we
wait for MapLibre Compose changes to hit the upstream - more details can be found e.g. here.
Reviewing and testing is welcome by anyone interested, though!)

[mnalis]

Shouldn't that be named LGBTIncludedCountries (or just LGBTCountries)? Because it uses AllCountriesExcept which reverses the meaning of included lists

[Helium314]

just a quick note that merging of SCEE PRs is on temporary hold

Not on hold any more!

@jan-leila I'll merge the latest changes (since I still remember what needs to be changed), so it works with the changed SC quest forms, and then have another look.
(only need to wait a little more though, looks like current upstream SC doesn't compile, and thus SCEE has the same problem)

There's a bunch of things that need to be moved to the correct directories (there is no main any more, and strings go to strings_ee)