Skip to content

Conversation

@ravenfeld
Copy link

I'm going to split the request in 2.
#443

Creating a quest to add roof material

The most complicated part is making the images once you understand how it works ;)

Screenshot_20240702_223022

@Helium314
Copy link
Owner

Similar to builing material quest: please reduce size of the images, it's more than 5 MB currently, and the strings could be re-used (after building material quest is merged).
Other than that it's mostly minor things:

  • not sure if tin and generic metal should be separate. I wouldn't be able to tell that a roof is made of tin, probably same for zinc. But maybe it's easy if you have some experience.
  • I found the concrete and tar paper images not really helpful. For tar paper, just some increased contrast might help a lot (and maybe for concrete too)
  • the asphalt image looks strange, on my phone at first I thought it was a lake
  • quest icon could be nicer, but at the same time making a nice looking tile roof or whatever seems to be not worth the effort

@ravenfeld ravenfeld force-pushed the feature/add_roof_material branch from 617a9a9 to 29195c7 Compare May 3, 2025 16:31
@ravenfeld
Copy link
Author

@Helium314 I have updated this PR if it is still requested by some

@Helium314
Copy link
Owner

Thanks @ravenfeld!
I'll do another test run soon. From code I see you still using completely new strings for all materials, but we could reuse some of the existing strings e.g. for bamboo. But I can change this myself if you prefer.

@Helium314
Copy link
Owner

Helium314 commented May 4, 2025

I did a short test, and sometimes found it surprisingly difficult. But I'm far from an expert on those materials.

One thing I found that might warrant adding a hint: Where to Eternit plates / tiles go? Are they roof tiles or Eternit? The Eternit image shows only corrugated sheet, and I'm not sure whether it could also count as roof tiles. Similar questions could arise for other things like solar panel roof tiles.

@ravenfeld
Copy link
Author

@Helium314
I'll look into the strings this week. For the rest, I'm no expert. I just took a question that some people were asking about and looked at the wiki. Maybe we should check with them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants