Allow overriding country restrictions

[mnalis]

... in some quests only (where there is no community opposition; i.e. it is blocked due to spamminess or expert knowledge requirements. Few quests are added, the list may be extended upon request.

Please suggest which of the other quests user should be able to override (and which should not!)

Fixes: #619

Here is latest debug .apk for testing. Feedback welcome!

Should be implemented for ( ✔️ means already finished!)

• AddFireHydrantDiameter.kt
• AddFireHydrantRef.kt
• AddSummitRegister.kt
• AddSummitCross.kt
• AddPostboxRef.kt
• AddPostboxCollectionTimes.kt
• AddBusStopRef.kt
• AddTactilePavingSteps.kt
• AddTactilePavingCrosswalk.kt
• AddTactilePavingKerb.kt
• AddTactilePavingBusStop.kt
• AddEntranceReference.kt
• AddRailwayPlatformRef.kt

---

Should (probably) not be implemented for ( ✔️ means verified it should NOT be overriden):

• AddProhibitedForPedestrians.kt - no GB (community poll)
• AddRoadName: no, roads in Japan don't have names
• AddPoliceType: no, specific to italy
• AddTrafficSignalsVibration.kt - ?? quest was requested to be disabled in those countries, but reason was being spammy / useless
• AddCycleway: ??, seems to be restricted because spammy
• AddMaxSpeed: ??, "generic" limits are useless and should not be added
• DetermineRecyclingGlass: ??, spammy / useless in CZ and maybe was requested to be disabled
• AddAddressStreet.kt - no JP; "In Japan, housenumbers usually have block numbers, not streets"
• AddMopedAccess.kt - mostly BE specific
• AddIsPharmacyDispensing.kt - few countries indicated it is useless there, so only they are excluded
• AddBusStopName.kt - only US, CA opted out, so only they are excluded
• AddToiletsFee.kt - only US, CA opted out, so only they are excluded
• AddHousenumber.kt - several countries opted out, so only they are excluded
• AddPostboxRoyalCypher.kt - only exists is several countries (if any more exist, they should be enabled for them!)
• AddAcceptsCash.kt (maybe? too spammy?)
• AddFuelSelfService.kt - (maybe: but spammy in most countries?)

[rusty-snake]

• AddRoadName.kt
  • AllCountriesExcept("JP")
• AddTrafficSignalsVibration.kt
  • AllCountriesExcept("BG", "FI", "RU")
• AddSummitRegister.kt
  • NoCountriesExcept("AT", "CH", "CZ", "DE", "ES", "FR", "GR", "IT", "RO", "SI", "SK", "AR", "PE", "US")
• AddSummitCross.kt
  • NoCountriesExcept("AT", "CH", "CO", "DE", "ES", "FR", "IT", "PL", "RO", "SK", "AR", "PE")
• AddFuelSelfService.kt
  • NoCountriesExcept("IT", "UK")
  • spammy in the most countries
• AddCycleway.kt
  • NoCountriesExcept(... long list ...)
• AddPostboxRef.kt
  • NoCountriesExcept("FR", "GB", "GG", "IM", "JE", "MT", "IE", "SG", "CZ", "SK", "CH", "US")
• AddMaxSpeed.kt
  • AllCountriesExcept("US")
• AddPoliceType.kt
  • NoCountriesExcept("IT")
• AddPostboxCollectionTimes.kt
  • NoCountriesExcept(... long list ...)
• AddAcceptsCash.kt
  • NoCountriesExcept("FI", "GB", "SE", "NL")
• DetermineRecyclingGlass.kt
  • AllCountriesExcept("CZ")
• AddIsPharmacyDispensing.kt
  • AllCountriesExcept("AT", "DE", "FR", "PL")
• AddRailwayPlatformRef.kt
  • NoCountriesExcept("DE", "FR", "CH", "AT")
• OsmoseQuest.kt
  • ...
• AddHousenumber.kt
  • AllCountriesExcept(...)
• AddAddressStreet.kt
  • AllCountriesExcept("JP")
  • "In Japan, housenumbers usually have block numbers, not streets"
• AddBusStopName.kt
  • AllCountriesExcept("US", "CA")
• AddBusStopRef.kt
  • NoCountriesExcept(...)
• AddProhibitedForPedestrians.kt
  • AllCountriesExcept("GB")
  • Disabled because of community poll
• AddTactilePavingSteps.kt
  • COUNTRIES_WHERE_TACTILE_PAVING_IS_COMMON
• AddTactilePavingCrosswalk.kt
  • COUNTRIES_WHERE_TACTILE_PAVING_IS_COMMON
• AddTactilePavingKerb.kt
  • COUNTRIES_WHERE_TACTILE_PAVING_IS_COMMON
• AddTactilePavingBusStop.kt
  • COUNTRIES_WHERE_TACTILE_PAVING_IS_COMMON
• AddPostboxRoyalCypher.kt
  • NoCountriesExcept("GB", "GI", "CY", "HK", "MT")
• AddToiletsFee.kt
  • AllCountriesExcept("US", "CA")
• AddMopedAccess.kt
  • NoCountriesExcept("BE")
  • My opinion: Germany: There are no traffic signs for the moped key. Users would confuse it with the mofa key (which should be asked only for urban cycleways as rural cyclways have a default of mofa=yes).
• AddEntranceReference.kt
  • NoCountriesExcept("PL", "RU", "MK", "BG", "UA", "BY", "EE", "HU", "RO")

[Helium314]

Had a look at a few quests (thanks for the links @rusty-snake), and my opinion whether to allow override;
AddRoadName: no, roads in Japan don't have names
AddTrafficSignalsVibration: ??, quest was requested to be disabled in those countries, but reason was being spammy / useless
AddSummitRegister: yes
AddSummitCross: yes
AddFuelSelfService: yes
AddCycleway: ??, seems to be restricted because spammy
AddPostboxRef: yes
AddMaxSpeed: ??, "generic" limits are useless and should not be added
AddPoliceType: no, specific to italy
AddPostboxCollectionTimes: yes
AddAcceptsCash: yes
DetermineRecyclingGlass: ??, spammy / useless in CZ and maybe was requested to be disabled

[mnalis]

Thanks @rusty-snake & @Helium314!

I've updated list at the top, as to start with those which should be not problematic, so I can do this PR with them (other quests can always be added later if people ask for them)...

If anybody has further opinions on those in "probably should not be implemented" (or of course in the "Should be implemented" list!) let me know.

[mnalis]

debug .apk for test here, if someone wants to try it out and let me know how it works for them.

[Helium314]

@rusty-snake @FloEdelmann any opinions on the current list?
Looks fine to me.

[rusty-snake]

Not an expert in all topics but the current list looks good (overall).

AddAcceptsCash.kt

It is to spammy in some countries/regions/cities where cash/cash-only is the norm. However it is a NoCountriesExcept with 4 countries and I expected that there are more countries (or parts like big cities) where it could be interesting.

Is there some kind of warning when overriding country restrictions?

[Helium314]

Right, it could be useful in some areas.

Is there some kind of warning when overriding country restrictions?

Currently not, only this text is shown below the setting:
"Allow quests to be asked everywhere, even if originally disabled in some countries. Note that some quests still may not be overridden due to community consensus."

[mnalis]

Is there some kind of warning when overriding country restrictions?

Not currently, because it looked somewhat complex in similar examples I found (and I don't know enough Kotlin to add it simpler way). 😅

But I probably should add a warning anyway (even if original idea was to override only quest where it is quite unlikely anybody will complain about overtagging, so it was perhaps not strictly necessary).

It is to spammy in some countries/regions/cities where cash/cash-only is the norm. However it is a NoCountriesExcept with 4 countries and I expected that there are more countries (or parts like big cities) where it could be interesting.

Do you (or anyone else) have such example region where it would be useful (i.e. where you'd be using it)? If so, I guess we can enable it after adding the warning...

[Helium314]

But I probably should add a warning anyway

If the warning is short, I think it would be fine to simply have it in the text below the setting.

[Helium314]

@mnalis @rusty-snake how about something like

Allow quests to be asked everywhere, even if originally disabled in some countries because they are mostly useless or spammy. Please be considerate when answering those quests. Note that some quests still may not be overridden due to community consensus.

Would this be enough warning e.g. for AddAcceptsCash?

[mnalis]

Would this be enough warning e.g. for AddAcceptsCash?

I've improved the text as you suggested, but I'm still somewhat afraid it might case backlash if users start tagging payment:cash=yes massively in countries where it is implied (I'm having flashbacks of lit=no in SC; but then again SCEE is much smaller userbase, so perhaps it won't be noticeable).

So if you think it it fine, we can go with that, I'm not opposed...

I'd prefer to add explicit warning dialog which user must confirm if such potentially-problematic quests like AddAcceptsCash are overridden; but I won't have any time to look at it for at least 8-10 days (SotM Croatia is coming up, and it will increase my backlog)

[Helium314]

It's not urgent anyway. You should be able to copy code for displaying the warning from the expert mode switch.

[FloEdelmann]

Looks good to me 🙂
Thanks for implementing this!