build: idapython: Fix pywraps.hpp path and move CMake support to plugin#47
Open
0xeb wants to merge 1 commit into
Open
build: idapython: Fix pywraps.hpp path and move CMake support to plugin#470xeb wants to merge 1 commit into
0xeb wants to merge 1 commit into
Conversation
0xeb
force-pushed
the
cmake-idapython
branch
2 times, most recently
from
20692ae to
4b02f0f
Compare
- Replace hardcoded #include "../../../pywraps.hpp" with parameterized path via genswigheader.py --pywraps-dir (defaults to ../../.. for GNU Make backward compatibility) - Move IDAPythonSupport.cmake from ida-cmake submodule to src/plugins/idapython/cmake/ (keeps submodule generic) - Remove configure_file() hack that copied headers to source tree - Fix additional hardcoded paths in swig/diskio.i and swig/nalt.i - Enable idapython subdirectory in plugins build
Collaborator
|
Hey @0xeb , thanks for putting this together! We actually have an ongoing CMake idapython build effort internally that we're planning to ship. I'd prefer to hold off on merging this for now and instead align both efforts - that way we avoid having to rework things after the fact. Would you be okay with that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include "../../../pywraps.hpp"inheader.i.inwith a parameterized path viagenswigheader.py --pywraps-dir, eliminating source tree pollution from theconfigure_file()copy hackIDAPythonSupport.cmakefrom theida-cmakesubmodule intosrc/plugins/idapython/cmake/so IDAPython owns its own build pipeline and the submodule stays genericidapythonsubdirectory in the plugins buildBackward compatible:
--pywraps-dirdefaults to../../..so GNU Make builds produce identical output.