feat(cudf): Support Spark string-to-decimal try_cast - #34
Draft
thirtiseven wants to merge 1 commit into
Draft
Conversation
Selective Build Plan
Selective build plan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try_cast(VARCHAR AS DECIMAL).Motivation
Velox short decimals use an integral physical type, so the cuDF expression adapter previously classified a string-to-decimal cast as a string-to-integer cast. Long decimals were rejected outright. libcudf's fixed-point parser is not a semantic substitute because it truncates fractional values where Spark rounds HALF_UP.
The conversion kernel is adapted from the Apache-licensed
NVIDIA/spark-rapids-jniimplementation, with additional validation for whitespace-only strings and incomplete mantissa or exponent forms.Scope
This PR supports non-ANSI
try_castonly. It does not change generic cast behavior, introduce a runtime dependency on RAPIDS JNI, or affect non-decimal cast paths.Validation
velox_cudf_spark_string_to_decimal_test: 5/5 passed.