feat(cudf): Support map construction and element lookup - #61
Open
winningsix wants to merge 1 commit into
Open
Conversation
Collaborator
|
Plz fix the format issues |
thirtiseven
reviewed
Aug 17, 2026
| VELOX_CHECK_EQ(nextInputColumnIndex, inputColumns.size()); | ||
|
|
||
| auto keys = | ||
| cudf::interleave_columns(cudf::table_view(keyViews), stream, mr); |
Collaborator
There was a problem hiding this comment.
Blocking: this preserves duplicate keys, while the Spark CPU MapFunction either applies LAST_WIN or throws when throw_exception_on_duplicate_map_keys is enabled. Since the new map lookup uses FIND_FIRST, element_at(map("k", c0, "k", c1), "k") returns c0 on GPU but c1 on CPU. Please implement the same duplicate-key policy (including the exception mode), or fail GPU selection when uniqueness cannot be guaranteed, and add literal/dynamic duplicate-key parity tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIST<STRUCT<K,V>>and preserve sliced offsets and parent validityelement_atmap lookups through cuDFTesting