tried fixing build actions#176
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideComments out the system dependency installation section in the AppImage build script, delegating that responsibility to the CI YAML configuration instead. Flow diagram for updated build_appimage_sh scriptflowchart TD
A[Start build_appimage_sh] --> B[set -euo pipefail]
B --> C[ls -la]
C --> D{Install system libraries?}
D -->|No, handled in CI YAML| E[Skip apt-get and requirements-system]
E --> F{python3 available?}
F -->|Yes| G[Set PYTHON=python3]
F -->|No| H[Set PYTHON=python]
G --> I[Continue AppImage build steps]
H --> I[Continue AppImage build steps]
I --> Z[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of commenting out the system dependency installation block, consider removing it or guarding it behind an environment flag so the script can still be used outside of the CI YAML while avoiding duplicated work in the workflow.
- The inline comment
## COMMENTED BECAUSE ALREADY HANDELED IN YAMLis a bit vague and contains a typo; clarify which YAML/workflow handles these steps and correct the wording so future maintainers understand why this block is disabled.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of commenting out the system dependency installation block, consider removing it or guarding it behind an environment flag so the script can still be used outside of the CI YAML while avoiding duplicated work in the workflow.
- The inline comment `## COMMENTED BECAUSE ALREADY HANDELED IN YAML` is a bit vague and contains a typo; clarify which YAML/workflow handles these steps and correct the wording so future maintainers understand why this block is disabled.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed it. :)
Summary by Sourcery
Build: