Skip to content

tried fixing build actions#176

Merged
Splayer0 merged 1 commit into
Hogjects:feature-win-tweaksfrom
Splayer0:feature-win-tweaks
May 5, 2026
Merged

tried fixing build actions#176
Splayer0 merged 1 commit into
Hogjects:feature-win-tweaksfrom
Splayer0:feature-win-tweaks

Conversation

@Splayer0
Copy link
Copy Markdown
Collaborator

@Splayer0 Splayer0 commented May 5, 2026

fixed it. :)

Summary by Sourcery

Build:

  • Update AppImage build script to remove in-script apt-based system dependency installation in favor of YAML-managed setup.

@Splayer0 Splayer0 added Bug Something isn't working as expected Backend This is for errors or enhancements that are relevant to Backend labels May 5, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Comments out the system dependency installation section in the AppImage build script, delegating that responsibility to the CI YAML configuration instead.

Flow diagram for updated build_appimage_sh script

flowchart TD
    A[Start build_appimage_sh] --> B[set -euo pipefail]
    B --> C[ls -la]
    C --> D{Install system libraries?}
    D -->|No, handled in CI YAML| E[Skip apt-get and requirements-system]
    E --> F{python3 available?}
    F -->|Yes| G[Set PYTHON=python3]
    F -->|No| H[Set PYTHON=python]
    G --> I[Continue AppImage build steps]
    H --> I[Continue AppImage build steps]
    I --> Z[End]
Loading

File-Level Changes

Change Details Files
Disable in-script system dependency installation in favor of CI YAML-managed setup.
  • Commented out the apt-get update/upgrade and package installation commands in the AppImage build script
  • Left the rest of the build script unchanged, preserving Python detection and subsequent steps
scripts/build-appimage.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Splayer0 Splayer0 merged commit 632824f into Hogjects:feature-win-tweaks May 5, 2026
9 checks passed
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of commenting out the system dependency installation block, consider removing it or guarding it behind an environment flag so the script can still be used outside of the CI YAML while avoiding duplicated work in the workflow.
  • The inline comment ## COMMENTED BECAUSE ALREADY HANDELED IN YAML is a bit vague and contains a typo; clarify which YAML/workflow handles these steps and correct the wording so future maintainers understand why this block is disabled.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of commenting out the system dependency installation block, consider removing it or guarding it behind an environment flag so the script can still be used outside of the CI YAML while avoiding duplicated work in the workflow.
- The inline comment `## COMMENTED BECAUSE ALREADY HANDELED IN YAML` is a bit vague and contains a typo; clarify which YAML/workflow handles these steps and correct the wording so future maintainers understand why this block is disabled.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend This is for errors or enhancements that are relevant to Backend Bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant