I'll redo this fr by Radiump123 · Pull Request #186 · Hogjects/Lufus

Radiump123 · 2026-05-07T23:08:35Z

No description provided.

with '' will be ignored, and an empty message aborts the commit. On branch dev Your branch is up to date with 'origin/dev'. Changes to be committed: new file: build-musl.sh new file: build.sh

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : supprimé : build-musl.sh supprimé : build.sh

Veuillez saisir le message de validation pour vos modifications. Les lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : nouveau fichier : deps.txt

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est en avance sur 'origin/dev' de 1 commit. (utilisez "git push" pour publier vos commits locaux) Modifications qui seront validées : modifié : src/lufus/writing/install_ventoy.py modifié : src/lufus/writing/windows/flash.py modifié : src/lufus/writing/windows/tweaks.py

into feature-win-tweaks

Please enter the commit message for your changes. Lines starting with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: src/lufus/drives/find_usb.py modified: src/lufus/drives/get_usb_info.py modified: tests/test_find_usb.py modified: tests/test_flash_usb_and_find_usb_fixes.py modified: tests/test_get_usb_info.py

Please enter the commit message for your changes. Lines starting with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is ahead of 'origin/less-deps-feature-win-tweaks' by 1 commit. (use "git push" to publish your local commits) Changes to be committed: modified: tests/test_get_usb_info_and_detect_windows_fixes.py

Please enter the commit message for your changes. Lines starting with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: src/lufus/writing/flash_usb.py

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: src/lufus/drives/get_usb_info.py new file: tests/conftest.py modified: tests/test_find_usb.py modified: tests/test_flash_usb_and_find_usb_fixes.py modified: tests/test_get_usb_info.py modified: tests/test_get_usb_info_and_detect_windows_fixes.py

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: .github/workflows/python-compatibility.yml

…ting" This reverts commit dc34beb. Please enter the commit message for your changes. Lines starting with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: src/lufus/drives/get_usb_info.py deleted: tests/conftest.py modified: tests/test_find_usb.py modified: tests/test_flash_usb_and_find_usb_fixes.py modified: tests/test_get_usb_info.py modified: tests/test_get_usb_info_and_detect_windows_fixes.py

This reverts commit f77fd1c. Please enter the commit message for your changes. Lines starting with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: src/lufus/writing/flash_usb.py

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: README.md

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: .github/workflows/ci.yml modified: src/lufus/drives/get_usb_info.py modified: tests/test_find_usb.py modified: tests/test_flash_usb_and_find_usb_fixes.py modified: tests/test_get_usb_info.py modified: tests/test_get_usb_info_and_detect_windows_fixes.py Untracked files: TODO

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: .github/workflows/ci.yml modified: .github/workflows/python-compatibility.yml modified: pyproject.toml modified: scripts/build-appimage.sh modified: src/lufus/drives/find_usb.py modified: src/lufus/drives/formatting.py modified: src/lufus/drives/get_usb_info.py modified: src/lufus/gui/dialogs.py modified: src/lufus/gui/gui.py modified: src/lufus/gui/i18n.py modified: src/lufus/gui/languages/Deutsch.csv modified: src/lufus/gui/languages/English.csv modified: "src/lufus/gui/languages/Espa\303\261ol.csv" modified: "src/lufus/gui/languages/Fran\303\247ais.csv" modified: "src/lufus/gui/languages/Portugue\314\202s Brasileiro.csv" modified: src/lufus/gui/languages/Svenska.csv modified: "src/lufus/gui/languages/\320\240\321\203\321\201\321\201\320\272\320\270\320\271.csv" modified: "src/lufus/gui/languages/\321\203\320\272\321\200\320\260\321\227\320\275\321\201\321\214\320\272\320\260.csv" modified: "src/lufus/gui/languages/\330\271\330\261\330\250\331\212.csv" modified: "src/lufus/gui/languages/\340\246\254\340\246\276\340\246\202\340\246\262\340\246\276.csv" modified: src/lufus/gui/workers.py modified: src/lufus/state.py modified: src/lufus/utils.py modified: src/lufus/writing/flash_usb.py modified: src/lufus/writing/install_ventoy.py modified: src/lufus/writing/windows/flash.py modified: src/lufus/writing/windows/tweaks.py modified: tests/test_find_usb.py modified: tests/test_flash_usb_and_find_usb_fixes.py modified: tests/test_get_usb_info.py modified: tests/test_get_usb_info_and_detect_windows_fixes.py Untracked files: Archive.tar.gz TODO root-log.txt src/lufus/gui/languages/U0420U0443U0441U0441U043aU0438U0439.csv src/lufus/gui/languages/U0443U043aU0440U0430U0457U043dU0441U044cU043aU0430.csv src/lufus/gui/languages/U0639U0631U0628U064a.csv src/lufus/gui/languages/U09acU09beU0982U09b2U09be.csv src/lufus/gui/languages/EspaU00f1ol.csv src/lufus/gui/languages/FranU00e7ais.csv src/lufus/gui/languages/PortugueU0302s Brasileiro.csv user-log.txt

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is ahead of 'origin/less-deps-feature-win-tweaks' by 1 commit. (use "git push" to publish your local commits) Changes to be committed: modified: src/lufus/gui/gui.py new file: src/lufus/gui/languages/U0420U0443U0441U0441U043aU0438U0439.csv new file: src/lufus/gui/languages/U0443U043aU0440U0430U0457U043dU0441U044cU043aU0430.csv new file: src/lufus/gui/languages/U0639U0631U0628U064a.csv new file: src/lufus/gui/languages/U09acU09beU0982U09b2U09be.csv new file: src/lufus/gui/languages/EspaU00f1ol.csv new file: src/lufus/gui/languages/FranU00e7ais.csv new file: src/lufus/gui/languages/PortugueU0302s Brasileiro.csv modified: src/lufus/writing/flash_usb.py

Please enter the commit message for your changes. Lines starting with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is ahead of 'origin/less-deps-feature-win-tweaks' by 2 commits. (use "git push" to publish your local commits) Changes to be committed: deleted: src/lufus/gui/languages/U0420U0443U0441U0441U043aU0438U0439.csv deleted: src/lufus/gui/languages/U0443U043aU0440U0430U0457U043dU0441U044cU043aU0430.csv deleted: src/lufus/gui/languages/U0639U0631U0628U064a.csv deleted: src/lufus/gui/languages/U09acU09beU0982U09b2U09be.csv deleted: src/lufus/gui/languages/EspaU00f1ol.csv deleted: src/lufus/gui/languages/FranU00e7ais.csv deleted: src/lufus/gui/languages/PortugueU0302s Brasileiro.csv

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is ahead of 'origin/less-deps-feature-win-tweaks' by 3 commits. (use "git push" to publish your local commits) Changes to be committed: modified: src/lufus/gui/gui.py

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : .github/workflows/ci.yml

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : scripts/build-appimage.sh modifié : src/lufus/drives/formatting.py modifié : src/lufus/gui/i18n.py modifié : src/lufus/utils.py modifié : src/lufus/writing/flash_usb.py modifié : tests/test_flash_usb_and_find_usb_fixes.py

Veuillez saisir le message de validation pour vos modifications. Les lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est en avance sur 'origin/less-deps-feature-win-tweaks' de 1 commit. (utilisez "git push" pour publier vos commits locaux) Modifications qui seront validées : modifié : src/lufus/gui/gui.py modifié : src/lufus/writing/windows/detect.py

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : src/lufus/drives/formatting.py modifié : tests/test_flash_usb_and_find_usb_fixes.py

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : tests/test_flash_usb_and_find_usb_fixes.py

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : tests/test_linux_iso_detection.py

… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : src/lufus/drives/formatting.py modifié : src/lufus/gui/gui.py modifié : src/lufus/utils.py modifié : src/lufus/writing/windows/flash.py modifié : src/lufus/writing/windows/tweaks.py

Veuillez saisir le message de validation pour vos modifications. Les lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche less-deps-feature-win-tweaks Votre branche est à jour avec 'origin/less-deps-feature-win-tweaks'. Modifications qui seront validées : modifié : src/lufus/writing/windows/flash.py

Removed LSBLK dependency, fixed progress bar. (Issue Hogjects#178, partially Hogjects#171)

Splayer0 · 2026-05-08T07:26:28Z

@Radiump123 we shifted the branch from future-win-tweaks to dev...

Hog185 · 2026-05-08T07:58:02Z

hi, im shutting this pr down for a few reasons,

please declare all ai.
this code is backwards and doesnt make sense, if you are gonna use ai, at least make sure you know what the ai is changing
commit messages are unhelpful and confusing
half of it doesnt work and is clearly untested

Radiump123 · 2026-05-08T12:20:11Z

hi, im shutting this pr down for a few reasons,

please declare all ai.

this code is backwards and doesnt make sense, if you are gonna use ai, at least make sure you know what the ai is changing

commit messages are unhelpful and confusing

half of it doesnt work and is clearly untested

Did not use AI, it's more a mix of 4AM coding and ADHD, I'll try doing better.

Radiump123 · 2026-05-08T20:21:48Z

hi, im shutting this pr down for a few reasons,

please declare all ai.

this code is backwards and doesnt make sense, if you are gonna use ai, at least make sure you know what the ai is changing

commit messages are unhelpful and confusing

half of it doesnt work and is clearly untested

Did not use AI, it's more a mix of 4AM coding and ADHD, I'll try doing better.

Why the thumb down?

R. Larocque and others added 30 commits May 5, 2026 09:14

Please enter the commit message for your changes. Lines starting

c6ce91f

with '' will be ignored, and an empty message aborts the commit. On branch dev Your branch is up to date with 'origin/dev'. Changes to be committed: new file: build-musl.sh new file: build.sh

Update tweaks.py

5af1dce

Merge branch 'feature-win-tweaks' of https://github.com/Radiump123/Lufus

ca85a98

into feature-win-tweaks

Please enter the commit message for your changes. Lines starting

cb60160

with '' will be ignored, and an empty message aborts the commit. On branch less-deps-feature-win-tweaks Your branch is up to date with 'origin/less-deps-feature-win-tweaks'. Changes to be committed: modified: README.md

Add pyudev to Python Compatibility workflow

f227f74

Fix test FakeStderr to use read1() for progress parsing

2ece545

Merge pull request #3 from Radiump123/less-deps-feature-win-tweaks

97b6a4d

Removed LSBLK dependency, fixed progress bar. (Issue Hogjects#178, partially Hogjects#171)

Radiump123 marked this pull request as ready for review May 7, 2026 23:09

Splayer0 marked this pull request as draft May 8, 2026 07:26

Hog185 closed this May 8, 2026

Radiump123 deleted the feature-win-tweaks branch May 8, 2026 13:03

Radiump123 changed the title Addressed #183, #178 and started addressing #171 by replacing some external tool calls by native Python. SourceryAI detects some stuff, but it's not fixable without major rewriting, so I ignored. Don't mind goofy commit messages. I'll redo this fr May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I'll redo this fr#186

I'll redo this fr#186
Radiump123 wants to merge 30 commits intoHogjects:feature-win-tweaksfrom
Radiump123:feature-win-tweaks

Radiump123 commented May 7, 2026

Uh oh!

Splayer0 commented May 8, 2026

Uh oh!

Hog185 commented May 8, 2026

Uh oh!

Radiump123 commented May 8, 2026

Uh oh!

Radiump123 commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Radiump123 commented May 7, 2026

Uh oh!

Splayer0 commented May 8, 2026

Uh oh!

Hog185 commented May 8, 2026

Uh oh!

Radiump123 commented May 8, 2026

Uh oh!

Radiump123 commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants