Conversation
- Fix unbound type parameter in AperturesMismatch constructor: replace
nodes::NTuple{N,K} (flagged by Test.detect_unbound_args for variadic
homogeneous tuples with variable N) with NTuple{N}, extracting K via
eltype(nodes) inside the body
- Move RegisterDriver and Aqua from [deps] to [extras]/[targets] — both
are test-only dependencies
- Add SharedArrays compat bound (stdlib dep was missing an entry)
- Wire Aqua.test_all into the test suite, suppressing the stale-deps
check for dynamically-loaded CUDA/RegisterMismatchCuda and the
piracy check for the intentional load_mm_package extension
- Add Aqua badge to README
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… construction Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The CUDA test block created a single `algorithm` (with dev=0) but then passed the non-CUDA `algorithms` array to `monitor` and `driver`, so the CUDA registration path was never exercised even on a GPU machine. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GPUArraysCore defaults to ScalarDisallowed outside interactive sessions, so RegisterMismatchCuda's scalar indexing caused Pkg.test() to hard-error. Wrap the driver call with CUDA.@allowscalar to make the intent explicit; also import CUDA in runtests.jl so the macro resolves. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add module docstring summarizing package purpose and entry points - Rewrite AperturesMismatch docstring: imperative mood, indented signature block, all keyword args documented, return type stated, monitored fields explained, broken Julia 0.6-era example replaced with working code - Add worker docstring: return annotation, tindex semantics, per-field return value descriptions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ples Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…A fixes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lause Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 65.93% 65.93%
=======================================
Files 1 1
Lines 91 91
=======================================
Hits 60 60
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… struct K (the element type of the nodes tuple) only annotated the nodes field and drove no dispatch. The auto-generated inner constructor with K in the where clause was flagged by Aqua as having an unbound type parameter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usingstatements insrc/and test coveragemutablefromAperturesMismatch(no fields are reassigned after construction)[algorithm]notalgorithmsto driver)Test plan
minand1Julia versions🤖 Generated with Claude Code