Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: finish expanding typed: strict #17643

Merged

Conversation

samford
Copy link
Member

@samford samford commented Jul 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I previously expanded use of typed: strict in livecheck files but the exception was livecheck/strategy.rb. This addresses the @strategies type errors in that file and upgrades it to typed: strict.

Related to #17297.

@samford samford force-pushed the livecheck/expand-typed-strict-2 branch from 91f4cf0 to d8a4b02 Compare July 7, 2024 11:51
I previously expanded use of `typed: strict` in livecheck files but
the exception was `livecheck/strategy.rb`. This addresses the
`@strategies` type errors in that file and upgrades it to
`typed: strict`.

Co-authored-by: apainintheneck <[email protected]>
@samford samford force-pushed the livecheck/expand-typed-strict-2 branch from d8a4b02 to 17d1561 Compare July 8, 2024 02:05
@samford samford mentioned this pull request Jul 8, 2024
7 tasks
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @samford!

@MikeMcQuaid MikeMcQuaid merged commit 341130f into Homebrew:master Jul 8, 2024
25 checks passed
@samford samford deleted the livecheck/expand-typed-strict-2 branch July 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants