-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorbet: Bump more files to typed: strict
#18004
Conversation
3955a02
to
74be9a1
Compare
74be9a1
to
92cab83
Compare
92cab83
to
0355f07
Compare
Co-authored-by: Carlo Cabrera <[email protected]>
a3ed94e
to
621ddc6
Compare
Co-authored-by: Bo Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks again @issyl0! Given how often these signatures sadly go 💥: let's hold off until after the next tag (which will be later today UK time, merge Tuesday UK time?)
Yeah, it would be great if there was a better way of testing them but I have no idea about that apart from going through every cmd. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?typed: strict
in all (non-package) files in Homebrew organisation #17297.