-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict typing in FormulaInstaller #18290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
force-pushed
the
strict-formula-installer
branch
from
September 8, 2024 23:35
4d3cb62
to
57a2bfa
Compare
dduugg
commented
Sep 8, 2024
dduugg
force-pushed
the
strict-formula-installer
branch
5 times, most recently
from
September 9, 2024 01:36
a4b063e
to
bec4d57
Compare
dduugg
commented
Sep 9, 2024
dduugg
force-pushed
the
strict-formula-installer
branch
from
September 9, 2024 02:45
bec4d57
to
254446b
Compare
MikeMcQuaid
approved these changes
Sep 9, 2024
Thanks @dduugg! Good to merge when conflicts addressed. |
dduugg
force-pushed
the
strict-formula-installer
branch
from
September 9, 2024 15:31
254446b
to
3c336f0
Compare
dduugg
commented
Sep 9, 2024
carlocab
approved these changes
Sep 9, 2024
dduugg
commented
Sep 9, 2024
reitermarkus
reviewed
Sep 9, 2024
reitermarkus
reviewed
Sep 9, 2024
dduugg
changed the title
Strict type FormulaInstaller
Enable strict typing in FormulaInstaller
Sep 10, 2024
Co-authored-by: Markus Reiter <[email protected]>
dduugg
force-pushed
the
strict-formula-installer
branch
from
September 10, 2024 17:11
bba0d5a
to
44970f7
Compare
carlocab
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dduugg!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?relates to #17297 #17998