Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github_runner_matrix: include 15-x86_64 with --all-supported #18362

Merged
merged 1 commit into from
Sep 19, 2024
Merged

github_runner_matrix: include 15-x86_64 with --all-supported #18362

merged 1 commit into from
Sep 19, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Part of #18356.

@carlocab carlocab requested a review from Bo98 September 19, 2024 16:28
carlocab
carlocab commented Sep 19, 2024
View reviewed changes
Library/Homebrew/github_runner_matrix.rb
@@ -181,7 +181,7 @@ def generate_runners!
)
@runners << create_runner(:macos, :arm64, spec, macos_version)

next if macos_version > NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER
next if !@all_supported && macos_version > NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth renaming NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER, though not really sure what name suits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah though not really sure either

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER_MOST_OF_THE_TIME

@carlocab carlocab merged commit b76debe into master Sep 19, 2024
27 checks passed
@carlocab carlocab deleted the github_runner_matrix-all_supported branch September 19, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlocab @Bo98