Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move to ubuntu latest #18704

Merged
merged 2 commits into from
Nov 4, 2024
Merged

ci: move to ubuntu latest #18704

merged 2 commits into from
Nov 4, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 2, 2024 •
edited
Loading

Add coverage test using ubuntu 24.04

Not changing the default build CI version for core yet.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

carlocab
carlocab approved these changes Nov 2, 2024
View reviewed changes
.github/workflows/autogenerated-files.yml Outdated Show resolved Hide resolved
@iMichka iMichka changed the title ci: move to ubuntu 24.04 ci: move to ubuntu latest Nov 3, 2024
@iMichka
ci: move to ubuntu latest
2f73ca1 
Add coverage test using ubuntu 24.04

Not changing the default build CI version for core yet.
carlocab
carlocab approved these changes Nov 3, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMichka!

@MikeMcQuaid MikeMcQuaid merged commit 824efa8 into master Nov 4, 2024
40 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ubuntu-run branch November 4, 2024 09:42
iMichka added a commit to Homebrew/homebrew-core that referenced this pull request Nov 5, 2024
@iMichka
ci: use ubuntu-latest
d657da2 
Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubunut-latest is equivalent to 22.04 right now so this does not change anything

Our ubuntu 22.04 docker image is still used (this has not been modified)
@iMichka iMichka mentioned this pull request Nov 5, 2024
Open
6 tasks
iMichka added a commit to Homebrew/homebrew-portable-ruby that referenced this pull request Nov 5, 2024
@iMichka
ci: use ubuntu-latest
bdd37a9 
Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubuntu-latest is equivalent to 22.04 right now so this does not change anything

Our ubuntu 22.04 docker image is still used (this has not been modified)
@iMichka iMichka mentioned this pull request Nov 5, 2024
Merged
iMichka added a commit to iMichka/formulae.brew.sh that referenced this pull request Nov 5, 2024
@iMichka
ci: use ubuntu-latest
ba5d920 
Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubuntu-latest is equivalent to 22.04 right now so this does not change anything
@iMichka iMichka mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 left review comments

@carlocab carlocab carlocab approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iMichka @MikeMcQuaid @Bo98 @carlocab