Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement fixes and comments for DisableComment rubocop #19168

Merged

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Jan 29, 2025

(Sorry I created this PR originally with gh pr create --fill, I didn't realise that would create a PR with empty PR body)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR should fix the last of the rubocop violations that are reported after #18842 is merged.

Copy link

request-info bot commented Jan 29, 2025

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Jan 29, 2025
@koddsson
Copy link
Contributor Author

Please provide a better issue/pull request title and/or description!

Done!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koddsson!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 31, 2025
Merged via the queue into Homebrew:master with commit 134fc44 Jan 31, 2025
28 checks passed
@koddsson koddsson deleted the fixes-for-disable-comment-rubocop branch January 31, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs response Needs a response from the issue/PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants